Skip to content

Fixes #213 : phone layout and add missing rename/delete actions#216

Open
sidharth-vijayan wants to merge 1 commit intoCodeChefVIT:prodfrom
sidharth-vijayan:prod
Open

Fixes #213 : phone layout and add missing rename/delete actions#216
sidharth-vijayan wants to merge 1 commit intoCodeChefVIT:prodfrom
sidharth-vijayan:prod

Conversation

@sidharth-vijayan
Copy link
Copy Markdown

Problem

#213

The saved timetables page had multiple issues on mobile:

  1. Missing rename and delete actions — the mobile component had no way to rename or delete a saved timetable, while the desktop version (saved.tsx) supported both. This was the most impactful regression.
  2. Orphaned divider bar during loading — the End of List divider rendered unconditionally, so a bare horizontal bar appeared on screen while timetables were still being fetched.
  3. Title overflow on short phonesmt-28 (112px) pushed the heading too far down on shorter devices, clipping content in some viewports.
  4. No tap feedback — list items had no visual response on tap.

Changes

  • Added handleDelete and handleRename functions mirroring saved.tsx logic
  • Added per-row ✏️ and 🗑️ buttons with inline modals for rename and delete
  • Unified the loading / empty state / list into a single if/else block so the divider only renders when the list is visible
  • Reduced title top margin from mt-28 to mt-20
  • Updated <li> grid to grid-cols-[auto_1fr_auto] to accommodate action buttons
  • Scoped onClick to title/index spans to prevent button click conflicts
  • Added active:opacity-70 transition-opacity tap feedback

@atharvaSharma17 atharvaSharma17 self-requested a review May 4, 2026 18:17
Copy link
Copy Markdown
Collaborator

@atharvaSharma17 atharvaSharma17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align this with the existing UI. Please use the shared icons instead of emojis and reuse the UI components already present rather than introducing new inline modals to maintain consistency and avoid duplicating UI logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants