Fixes #213 : phone layout and add missing rename/delete actions#216
Open
sidharth-vijayan wants to merge 1 commit intoCodeChefVIT:prodfrom
Open
Fixes #213 : phone layout and add missing rename/delete actions#216sidharth-vijayan wants to merge 1 commit intoCodeChefVIT:prodfrom
sidharth-vijayan wants to merge 1 commit intoCodeChefVIT:prodfrom
Conversation
atharvaSharma17
requested changes
May 4, 2026
Collaborator
atharvaSharma17
left a comment
There was a problem hiding this comment.
Align this with the existing UI. Please use the shared icons instead of emojis and reuse the UI components already present rather than introducing new inline modals to maintain consistency and avoid duplicating UI logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#213
The saved timetables page had multiple issues on mobile:
saved.tsx) supported both. This was the most impactful regression.End of Listdivider rendered unconditionally, so a bare horizontal bar appeared on screen while timetables were still being fetched.mt-28(112px) pushed the heading too far down on shorter devices, clipping content in some viewports.Changes
handleDeleteandhandleRenamefunctions mirroringsaved.tsxlogicif/elseblock so the divider only renders when the list is visiblemt-28tomt-20<li>grid togrid-cols-[auto_1fr_auto]to accommodate action buttonsonClickto title/index spans to prevent button click conflictsactive:opacity-70 transition-opacitytap feedback