feat(pinia-orm): hydrate recursively discriminated models#2037
Merged
Conversation
Discriminated models can now be nested over multiple levels (e.g. Document -> File -> Video). When hydrating a record, the type keys are walked down the hierarchy and an instance of the most specific matching type is created. make() now also resolves discriminated types, and nested type models are registered to the database. closes #1995
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2037 +/- ##
==========================================
+ Coverage 99.40% 99.47% +0.06%
==========================================
Files 82 82
Lines 3025 3046 +21
Branches 533 538 +5
==========================================
+ Hits 3007 3030 +23
+ Misses 15 13 -2
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature (#1995)
STI only resolved one discriminator level: a record for
Document -> File -> Videowas hydrated asFile, never asVideo.Model#$getDiscriminatedModel(record)walks nested type keys (each level may define its owntypeKey+types()) and returns the most specific matching model. Cycle-safe via a visited set (the self-referencing entries in inheritedtypes()maps terminate the walk).Query#getHydratedModel()(find/all/save hydration) andRepository#make()both use it —make()previously did no type resolution at all.useRepo()now registers nested type models to the database recursively, so saving into deep hierarchies resolves their entities.Tests
New STI test with a 3-level hierarchy (
Animal -> Dog -> Terrier, second discriminatorrace):make()resolves to the deepest type incl. its fields, intermediate and base types still resolve correctly, andfind()aftersave()returns the specific type. Full suite green (406 tests).closes #1995