fix: keep autofuzz from stalling in BigInteger(int, int, Random)#1059
Open
domzoric wants to merge 1 commit into
Open
fix: keep autofuzz from stalling in BigInteger(int, int, Random)#1059domzoric wants to merge 1 commit into
domzoric wants to merge 1 commit into
Conversation
Autofuzz can stall indefinitely when constructing arguments via BigInteger(int, int, Random), which searches for a random prime with up to Integer.MAX_VALUE bits. Introduce a denylist of constructors that are never considered during constructor discovery and add this constructor to it. Fixes CodeIntelligenceTesting#1055
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1055
In autofuzz mode, constructor discovery can pick
BigInteger(int, int, Random), which searches for a random prime with the given bit length and can take practically forever for large arguments, stalling the fuzzer.This adds a denylist of constructors that are never considered during constructor discovery in
AccessibleObjectLookupand putsBigInteger(int, int, Random)on it, as suggested in the issue. The denylist is a simple static set for now, so further problematic constructors can easily be added; making it user-configurable could be a follow-up if needed.Includes a unit test verifying that the denylisted constructor is filtered out while other
BigIntegerconstructors remain available.