Skip to content

GLASGOW | 26-ITP-JAN | Alasdair MacDonald | Sprint 1 | Object Destructuring#390

Closed
MacDonald91 wants to merge 2 commits intoCodeYourFuture:mainfrom
MacDonald91:sprint-1/destructuring
Closed

GLASGOW | 26-ITP-JAN | Alasdair MacDonald | Sprint 1 | Object Destructuring#390
MacDonald91 wants to merge 2 commits intoCodeYourFuture:mainfrom
MacDonald91:sprint-1/destructuring

Conversation

@MacDonald91
Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

completed exercises 1-3

Questions

I have no questions at this time.

@MacDonald91 MacDonald91 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 28, 2026
@Luro91 Luro91 added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 6, 2026
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the expected log in the console

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the implementation for task 2 of exercise 2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Task 2 is still missing

grandTotal += totalPence;

console.log(
`${quantity} ${itemName} ${totalPounds}`
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting of the total column looks a bit different than expected

QTY     ITEM                TOTAL
1       Hot cakes           2.32
2       Apple Pie           2.78
1       Egg McMuffin           2.80
1       Sausage McMuffin           3.00
2       Hot Coffee           2.00
4       Hash Brown           1.60

@Luro91 Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 6, 2026
@MacDonald91 MacDonald91 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 20, 2026
// ✅ destructuring inside loop
for (const { firstName, lastName, house, pet, occupation } of hogwarts) {
console.log(`${firstName} ${lastName} is a ${occupation} from ${house}`);
} No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the condition again? Task 1 should only log people from Gryffindor

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Task 2 is still missing

@Luro91 Luro91 removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 22, 2026
@MacDonald91 MacDonald91 closed this May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants