Manchester | 26-ITP-Jan | Ofonime Edak | Sprint 1 | Feature/Destructuring by Ofonimeedak · Pull Request #407 · CodeYourFuture/Module-Data-Flows

Ofonimeedak · 2026-04-05T21:32:37Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Update and destructuring argument for a function
Write a function for the teacher's pet
print receipt function

Luro91 · 2026-04-10T04:43:13Z

 }

-introduceYourself(personOne);
+ console.log(introduceYourself(personOne));


What does this log?

Luro91 · 2026-04-10T04:43:56Z

I don't see any console output here

It logs this message to the console: Hello, my name is Popeye. I am 34 years old and my favourite food is Spinach.

When I run this on my terminal: Module-Data-Flows\sprint-1\destructuring\exercise-1> node exercise.js

My comment refers to exercise 2

Luro91 · 2026-04-10T04:45:24Z

+    return totalCost;
+  }, 0);
+  const finalBill = grandTotal.toFixed(2);
+  console.log(`Total:${finalBill}`);


The formatting of the console output does not match the requirements

Luro91

Please apply the correct label next time when you need another review as I am using them to see where I need to rereview

Luro91 · 2026-04-13T15:10:27Z

My comment refers to exercise 2

Luro91 · 2026-04-13T15:11:37Z

+
+function orderReceipt(orderItems) {
+  const totalList = [];
+  console.log("QUANTITY  ITEM               TOTAL");


The text should say "QTY"

Thank you, I have worked on this. Please kindly review

This is still the same

Luro91 · 2026-04-16T04:26:53Z

+    const { firstName, lastName, house } = mate;
+    if (house === "Gryffindor") {
+      const gryffindorMates = `${firstName} ${lastName} lives in `;
+      console.log(gryffindorMates);


The output does not match the requirements:
I like the idea of making the logs more specific. However where do the people live in?

Harry Potter lives in Ron Weasley lives in Hermione Granger lives in Minerva McGonagall lives in Albus Dumbledore lives in Harry Potter has a pet Ron Weasley has a pet Hermione Granger has a pet Albus Dumbledore has a pet

Luro91 · 2026-04-19T06:14:10Z

+
+function orderReceipt(orderItems) {
+  const totalList = [];
+  console.log("QTY  ITEM               TOTAL");


The alignment of ITEM does not match:

QTY ITEM TOTAL 1 Hot cakes 2.32 2 Apple Pie 2.78 1 Egg McMuffin 2.80 1 Sausage McMuffin 3.00 2 Hot Coffee 2.00 4 Hash Brown 1.60 Total:14.50 -----------------

The item column is not aligned

QTY ITEM TOTAL 1 Hot cakes 2.32 2 Apple Pie 2.78 1 Egg McMuffin 2.80 1 Sausage McMuffin 3.00 2 Hot Coffee 2.00 4 Hash Brown 1.60 Total:14.50 -----------------

Luro91 · 2026-04-19T06:17:19Z

+
+//Task2
+
+function teacherWithPet(WizardAndWitch) {


How can you ensure that you only use teacheres for exercise 2?

- In exercise.jswrite a program that will take thehogwartsarray as input and display the names of teachers who have pets.

Task 2 should only show teachers who have a pet. At the moment it is everyone in the list.

Ofonimeedak · 2026-04-27T08:41:52Z

Please kindly review my latest changes

Luro91 · 2026-04-28T04:40:39Z

+function teacherWithPet(WizardAndWitch) {
+  for (let teacher of WizardAndWitch) {
+    const { firstName, lastName, pet,house } = teacher;
+    if (house === "Gryffindor" && pet!==null) {


Why are you checking for the house? Only teachers should be logged.

Thank you for your review. I have made changes. Please kindly have a look at the latest updates

Ofonimeedak · 2026-04-28T18:57:16Z

Please kindly review the latest update

illicitonion · 2026-05-04T16:58:34Z

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

Ofonimeedak added 3 commits April 5, 2026 20:51

ex-1-update-argument

fd42ed0

ex-2-teachers-pet

269406b

ex-3-print-receipt

3e0c968

Ofonimeedak added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Flows The name of the module. labels Apr 5, 2026

Luro91 added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 10, 2026

Luro91 reviewed Apr 10, 2026

View reviewed changes

Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 10, 2026

format receipt output

7d1585a

Ofonimeedak requested a review from Luro91 April 11, 2026 18:22

Luro91 reviewed Apr 13, 2026

View reviewed changes

fix task 2

be17291

Ofonimeedak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 15, 2026

Ofonimeedak requested a review from Luro91 April 15, 2026 10:42

Luro91 reviewed Apr 16, 2026

View reviewed changes

Luro91 removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 16, 2026

update heading to match spec.

c27521a

Ofonimeedak requested a review from Luro91 April 18, 2026 18:24

Ofonimeedak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 18, 2026

update QTY

d7d6d4a

Luro91 reviewed Apr 19, 2026

View reviewed changes

Luro91 removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 19, 2026

add pet type

0e7a1ac

Ofonimeedak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 19, 2026

Ofonimeedak requested a review from Luro91 April 19, 2026 16:16

Luro91 removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 22, 2026

realign header title

c4015ff

updated logic

c7ea35b

Luro91 reviewed Apr 28, 2026

View reviewed changes

add teacher with pet

65015e9

Ofonimeedak requested a review from Luro91 May 3, 2026 14:46

illicitonion closed this May 4, 2026

Uh oh!

Conversation

Ofonimeedak commented Apr 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Luro91 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Luro91 Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ofonimeedak commented Apr 27, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ofonimeedak commented Apr 28, 2026

Uh oh!

illicitonion commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Luro91 Apr 16, 2026 •

edited

Loading