Skip to content

Sheffield | 26-ITP-Jan | Mahammad Osman | Sprint 2 | Book Library#426

Closed
Darkidd77 wants to merge 15 commits intoCodeYourFuture:mainfrom
Darkidd77:feature/book-library
Closed

Sheffield | 26-ITP-Jan | Mahammad Osman | Sprint 2 | Book Library#426
Darkidd77 wants to merge 15 commits intoCodeYourFuture:mainfrom
Darkidd77:feature/book-library

Conversation

@Darkidd77
Copy link
Copy Markdown

@Darkidd77 Darkidd77 commented Apr 13, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Fixed missing parentheses that stopped books from showing on load.
  • Found and fixed a misspelled variable delBut → delButton using DevTools console error.
  • Fixed inverted read/unread logic so "Yes" and "No" display correctly.
  • Author field was missing from form validation — added it in.
  • Changed invalid input types type="title" and type="author" to type="text".
  • Gave the page an actual title instead of leaving it blank.
  • Form now clears itself after adding a book.

@Darkidd77 Darkidd77 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 13, 2026
cjyuan
cjyuan reviewed Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You made a good start and fix the bugs, but there are still some improvements you could make. Can you check (again) if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 16, 2026
@Darkidd77 Darkidd77 mentioned this pull request Apr 22, 2026
Open
@Darkidd77
Improve form input handling and validation in book submission
c98b896 
Co-authored-by: Copilot <copilot@github.com>
@Darkidd77 Darkidd77 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 23, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 23, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Apr 23, 2026

You need to move both your "TV Show" folders out of the Data Flow folder. They do not belong to the "Data Flow" repo.

@Darkidd77 Darkidd77 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 23, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 23, 2026
@Darkidd77 Darkidd77 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 23, 2026
cjyuan
cjyuan reviewed Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still quite some improvements you can make based on the
suggestions listed in the general feedback.
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js Outdated
@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 23, 2026
@cjyuan cjyuan added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Apr 23, 2026
@Darkidd77 Darkidd77 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 23, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Apr 24, 2026

Changes look good.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 24, 2026
@illicitonion
Copy link
Copy Markdown
Member

illicitonion commented May 4, 2026

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Darkidd77 @cjyuan @illicitonion