Glasgow | Jan-26 | Elisabeth Matulian | Sprint 3 | Programmer Humour#430
Closed
Elisabeth-Matulian wants to merge 7 commits intoCodeYourFuture:mainfrom
Closed
Glasgow | Jan-26 | Elisabeth Matulian | Sprint 3 | Programmer Humour#430Elisabeth-Matulian wants to merge 7 commits intoCodeYourFuture:mainfrom
Elisabeth-Matulian wants to merge 7 commits intoCodeYourFuture:mainfrom
Conversation
Elisabeth-Matulian
added
the
Needs Review
Luro91
added
the
Review in progress
Luro91
reviewed
Apr 18, 2026
Luro91
added
Reviewed
Elisabeth-Matulian
added
the
Needs Review
Luro91
reviewed
Apr 22, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
Well done.
A note on commits:
It's good practice to split commits into logical blocks (for example for each task or each review comment). This makes it easier to understand and additionally the commits could also be undone more easily if needed.
Luro91
added
Complete
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Practised using fetch
Questions
N/Q