London | Jan26 | Ihor Taradaiko | Sprint 1 | Object Destructuring#451
Closed
ihortar wants to merge 2 commits intoCodeYourFuture:mainfrom
Closed
London | Jan26 | Ihor Taradaiko | Sprint 1 | Object Destructuring#451ihortar wants to merge 2 commits intoCodeYourFuture:mainfrom
ihortar wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
ihortar
added
Needs Review
Luro91
added
the
Review in progress
Luro91
reviewed
Apr 23, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
Well done on task 1 and 2. Task 3 is only missing the proper indentation.
| for (let { quantity, itemName, unitPricePence } of order) { | ||
| const lineTotal = (quantity * unitPricePence) / 100; // Convert pence to pounds | ||
| total += lineTotal; | ||
| console.log(`${quantity}\t${itemName}\t\t${lineTotal.toFixed(2)}`); |
There was a problem hiding this comment.
The indentation does not match the requirements. How can you fix this?
QTY ITEM TOTAL
1 Hot cakes 2.32
2 Apple Pie 2.78
1 Egg McMuffin 2.80
1 Sausage McMuffin 3.00
2 Hot Coffee 2.00
4 Hash Brown 1.60
Total: 14.50
QTY ITEM TOTAL
1 Hot Cakes 2.32
2 Apple Pie 2.78
1 Egg McMuffin 2.80
1 Sausage McMuffin 3.00
2 Hot Coffee 2.00
4 Hash Brown 1.60
Total: 14.50
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist