Skip to content

BIRMINGHAM | 26-ITP-JAN | MERVE REIS | Sprint 2 | BOOK LIBRARY#455

Closed
mervereis wants to merge 7 commits intoCodeYourFuture:mainfrom
mervereis:data-flows
Closed

BIRMINGHAM | 26-ITP-JAN | MERVE REIS | Sprint 2 | BOOK LIBRARY#455
mervereis wants to merge 7 commits intoCodeYourFuture:mainfrom
mervereis:data-flows

Conversation

@mervereis
Copy link
Copy Markdown

@mervereis mervereis commented Apr 18, 2026

I fixed the bugs in the files .

@github-actions

This comment has been minimized.

Sign in to view
@mervereis mervereis changed the title BIRMINGHAM | 26-ITP-JAN | MERVE REIS | SPRINT2 BIRMINGHAM | 26-ITP-JAN | MERVE REIS | SPRINT2 | BOOK LIBRARY Apr 18, 2026
@github-actions

This comment has been minimized.

Sign in to view
@mervereis mervereis added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Flows The name of the module. labels Apr 18, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 18, 2026
@mervereis mervereis changed the title BIRMINGHAM | 26-ITP-JAN | MERVE REIS | SPRINT2 | BOOK LIBRARY BIRMINGHAM | 26-ITP-JAN | MERVE REIS | SPRINT-2 | BOOK LIBRARY Apr 18, 2026
@github-actions

This comment has been minimized.

Sign in to view
@mervereis mervereis closed this Apr 18, 2026
@mervereis mervereis reopened this Apr 18, 2026
@github-actions

This comment has been minimized.

Sign in to view
@mervereis mervereis added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 18, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 18, 2026
@mervereis mervereis closed this Apr 18, 2026
@mervereis mervereis reopened this Apr 18, 2026
@mervereis mervereis added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 18, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 18, 2026
@github-actions

This comment has been minimized.

Sign in to view
@mervereis mervereis added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 20, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 20, 2026
@mervereis mervereis changed the title BIRMINGHAM | 26-ITP-JAN | MERVE REIS | SPRINT-2 | BOOK LIBRARY BIRMINGHAM | 26-ITP-JAN | MERVE REIS | Sprint 2 | BOOK LIBRARY Apr 20, 2026
@github-actions

This comment has been minimized.

Sign in to view
@mervereis mervereis added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 20, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 20, 2026
@mervereis mervereis added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 20, 2026
cjyuan
cjyuan reviewed Apr 21, 2026
View reviewed changes
Comment thread debugging/book-library/script.js
Comment on lines +10 to 15
const book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
const book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
127,
true
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use different data types to represent page count?

Copy link
Copy Markdown
Author

@mervereis mervereis Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjyuan changed to string

Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 22, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are representing page count as number for new books added through sumbit() though.

Comment thread debugging/book-library/script.js Outdated
) {
const trimmedTitle = titleInput.value.trim();
const trimmedAuthor = authorInput.value.trim();
const trimmedPages = +pagesInput.value.trim();
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name "trimmedPages" tends to suggest it holds a string. Can you name it to better reflect that it holds a number?

Copy link
Copy Markdown
Author

@mervereis mervereis Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjyuan changed to trimmedPageNumbers

Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 22, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still has the suffix "trimmed". The variable is assigned a number, and normally numbers don't need to be trimmed.

Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js Outdated
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 21, 2026
@mervereis mervereis added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 22, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Apr 22, 2026

Overall changes look good.

There are still some inconsistency in the data representation of page count.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 22, 2026
@mervereis mervereis mentioned this pull request Apr 22, 2026
Open
@illicitonion
Copy link
Copy Markdown
Member

illicitonion commented May 4, 2026

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Flows The name of the module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mervereis @cjyuan @illicitonion