Skip to content

Sheffield | ITP-Jan-26 | Hayriye Saricicek | Sprint 2 | Book Library #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mshayriyesaricicek wants to merge 5 commits into from
Closed

Sheffield | ITP-Jan-26 | Hayriye Saricicek | Sprint 2 | Book Library #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ee161c1
made updates so form works and booklist can be updated, books deleted
mshayriyesaricicek Apr 19, 2026
e29edbc
made function loadDefaultBooks, changed accepted input for name and t…
mshayriyesaricicek Apr 21, 2026
388cbae
saved to format indents
mshayriyesaricicek Apr 21, 2026
8397ef9
implemented recommendations and made appropriate changes
mshayriyesaricicek Apr 23, 2026
d24a199
Fix library rendering, localStorage loading, and delete logic
mshayriyesaricicek Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 33 additions & 56 deletions debugging/book-library/index.html
View file
Open in desktop
Comment thread
cjyuan marked this conversation as resolved.
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
<!DOCTYPE html>
<html>
<!doctype html>
<html lang="en">
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<title>Book Library</title>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
Expand All @@ -28,46 +25,34 @@ <h1>Library</h1>
</button>

<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
name="author"
required
/>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
<label class="form-check-label">
<form id="bookForm">
<div class="form-group">
<label for="title">Title:</label>
<input
type="text"
title="Letters, numbers and basic punctuation only"
class="form-control"
id="title"
required
/>

<label for="author">Author: </label>
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
</div>
type="text"
class="form-control"
id="author"
title="Only letters, spaces, apostrophes and hyphens allowed"
required
/>
<label for="pages">Pages:</label>
<input type="number" class="form-control" id="pages" required />
<label class="form-check-label">
<input type="checkbox" class="form-check-input" id="check" />Read
</label>

<button type="submit" class="btn btn-primary">Enter</button>
</div>
</form>
</div>

<table class="table" id="display">
Expand All @@ -80,15 +65,7 @@ <h1>Library</h1>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>
<tbody></tbody>
</table>

<script src="script.js"></script>
Expand Down
184 changes: 120 additions & 64 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,103 +1,159 @@
let myLibrary = [];
const myLibrary = [];

window.addEventListener("load", function (e) {
populateStorage();
render();
});
function isValidAuthor(text) {
for (let char of text) {
const isLetter =
(char >= "a" && char <= "z") || (char >= "A" && char <= "Z");
Comment thread
cjyuan marked this conversation as resolved.

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
true
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
const isAllowedSymbol = ". ',&-".includes(char);

if (!isLetter && !isAllowedSymbol) {
return false;
}
}
return true;
}

function isValidTitle(text) {
for (let char of text) {
const isLetter =
(char >= "a" && char <= "z") || (char >= "A" && char <= "Z");

const isNumber = char >= "0" && char <= "9";

const isAllowedSymbol = " '.,!?&:-()\"".includes(char);

if (!isLetter && !isNumber && !isAllowedSymbol) {
return false;
}
}
return true;
}

function saveLibrary() {
localStorage.setItem("myLibrary", JSON.stringify(myLibrary));
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");
document.getElementById("bookForm").addEventListener("submit", function (e) {
e.preventDefault();

const title = document.getElementById("title").value;
const author = document.getElementById("author").value;
const pages = document.getElementById("pages").value;
const read = document.getElementById("check").checked;

if (!isValidAuthor(author)) {
alert("Invalid author name");
return;
}

if (!isValidTitle(title)) {
alert("Invalid book title");
return;
}

const success = populateStorage(title, author, pages, read);

if (!success) return; // ❗ STOP if invalid

render();
saveLibrary();

this.reset();
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems quite advanced. Are you familiar with the meaning of this in JS?

In Piscine, you may be asked something like this:

  • If you were not allowed to use this, how would you rewrite this.reset()?

Copy link
Copy Markdown
Author

@mshayriyesaricicek mshayriyesaricicek Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I couldn’t use this.reset(), I would manually reset each form field by setting their values back to empty. For example: document.getElementById("title").value = "";
document.getElementById("author").value = "";
document.getElementById("pages").value = "";
document.getElementById("check").checked = false;

Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use any code as long as can explain the code when asked. In Piscine's interview, the interviewer may randomly pick a piece of code from your project and ask you to explain it.

$("#demo").collapse("hide");
});

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
alert("Please fill all fields!");

function populateStorage(title, author, pages, check) {
if (!/^\d+$/.test(pages) || Number(pages) < 1 || Number(pages) > 5000) {
alert("Pages must be a whole number between 1 and 5000");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
}

let newBook = new Book(title, author, pages, check);
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you choose to keep the pages as string? It is not wrong, just unusual.

Copy link
Copy Markdown
Author

@mshayriyesaricicek mshayriyesaricicek Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ive changed it now

myLibrary.push(newBook);
return true;
}

function Book(title, author, pages, check) {
this.title = title;
this.author = author;
this.pages = pages;
this.pages = Number(pages);
this.check = check;
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
const tableBody = document.querySelector("#display tbody");
tableBody.innerHTML = "";

//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
myLibrary.forEach((book, i) => {
let row = tableBody.insertRow();
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
titleCell.innerText = book.title;
authorCell.innerText = book.author;
pagesCell.innerText = book.pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";

changeBut.className = book.check ? "btn btn-success" : "btn btn-secondary";

changeBut.innerText = book.check ? "Read" : "Unread";

wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
book.check = !book.check;
saveLibrary();
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
let delBut = document.createElement("button");

delBut.className = "btn btn-danger btn-sm";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);

deleteCell.appendChild(delBut);

delBut.addEventListener("click", function () {
const deletedTitle = book.title;
myLibrary.splice(myLibrary.indexOf(book), 1);
saveLibrary();
render();
Comment thread
cjyuan marked this conversation as resolved.
alert(`You've deleted title: ${deletedTitle}`);
});
}
});
}

function loadDefaultBooks() {
myLibrary.push(
new Book("Robinson Crusoe", "Daniel Defoe", "252", true),
new Book("The Old Man and the Sea", "Ernest Hemingway", "127", false)
);
}

window.onload = () => {
myLibrary.length = 0;

const saved = localStorage.getItem("myLibrary");

if (saved) {
const parsed = JSON.parse(saved);
if (Array.isArray(parsed) && parsed.length > 0) {
myLibrary.push(...parsed);
} else {
loadDefaultBooks();
}
} else {
loadDefaultBooks();
}
render();
};
Loading