Skip to content

London | 26-ITP-Jan | Maryanne Mosonik | Sprint 2 | Book Library #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Maryanne-K wants to merge 3 commits into from
Closed

London | 26-ITP-Jan | Maryanne Mosonik | Sprint 2 | Book Library #467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
160524c
Fix book submission bugs.
Maryanne-K Apr 21, 2026
1d10c7d
Refactor HTML structure and improve form input types
Maryanne-K Apr 21, 2026
bd831e3
Made further debugging changes to index.html and script.js
Maryanne-K Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 16 additions & 23 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,21 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<title>Book Library</title>
<meta
charset="utf-8"
charset="utf-8">
<meta
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>
<link rel="stylesheet" type="text/css" href="style.css" />
>
<link rel="stylesheet" type="text/css" href="style.css" >
</head>

<body>
Expand All @@ -31,45 +32,45 @@ <h1>Library</h1>
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
type="text"
class="form-control"
id="title"
name="title"
required
/>
>
<label for="author">Author: </label>
<input
type="author"
type="text"
class="form-control"
id="author"
name="author"
required
/>
>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
>
</div>
</div>

<div id="message"></div>
<table class="table" id="display">
<thead class="thead-dark">
<tr>
Expand All @@ -80,15 +81,7 @@ <h1>Library</h1>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>
<tbody></tbody>
</table>

<script src="script.js"></script>
Expand Down
125 changes: 66 additions & 59 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
let myLibrary = [];
const myLibrary = [];

window.addEventListener("load", function (e) {
populateStorage();
render();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
const book1 = new Book("Robinson Crusoe", "Daniel Defoe", 252, true);
const book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
127,
true
);
myLibrary.push(book1);
Expand All @@ -20,27 +19,29 @@ function populateStorage() {
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");
const titleInput = document.getElementById("title");
const authorInput = document.getElementById("author");
const pagesInput = document.getElementById("pages");
const checkInput = document.getElementById("check");
Comment on lines +22 to +25
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal practice is to declare all shared variables/constants at the beginning of the file, before function definition.


//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
const title = titleInput.value.trim();
const author = authorInput.value.trim();
const pages = Number(pagesInput.value);
const isRead = checkInput.checked;
if (!title || !author || pagesInput.value.trim() === "" ) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
return;
}
if (Number.isNaN(pages) || pages <= 0) {
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could input be a string representing a decimal number. e.g., "3.1416"?

alert("Please enter a valid number of pages!");
return;
}
const book = new Book(title, author, pages, isRead);
myLibrary.push(book);
render();
}

function Book(title, author, pages, check) {
Expand All @@ -50,54 +51,60 @@ function Book(title, author, pages, check) {
this.check = check;
}

function showMessage(text) {
const msg = document.getElementById("message");
msg.innerText = text;

setTimeout(() => {
msg.innerText = "";
}, 2000);
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
const table = document.getElementById("display");

table.innerHTML = table.rows[0].outerHTML;
myLibrary.forEach((book, index) => {
const row = table.insertRow();

const titleCell = row.insertCell(0);
const authorCell = row.insertCell(1);
const pagesCell = row.insertCell(2);
const wasReadCell = row.insertCell(3);
const deleteCell = row.insertCell(4);

titleCell.innerText = book.title;
authorCell.innerText = book.author;
pagesCell.innerText = book.pages;

//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;


//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
const toggleReadButton = document.createElement("button");
toggleReadButton.className = "btn btn-success";
toggleReadButton.innerText = book.check ? "Yes" : "No";

toggleReadButton.addEventListener("click", () => {
book.check = !book.check;
render();
});

wasReadCell.appendChild(toggleReadButton);

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
const deleteButton = document.createElement("button");
deleteButton.className = "btn btn-warning";
deleteButton.innerText = "Delete";

deleteButton.addEventListener("click", () => {
showMessage(`Book "${book.title}" deleted!`);
myLibrary.splice(index, 1);
Comment on lines +102 to +103
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safer to announce the deletion after the book has been successfully deleted.

render();
});
}

deleteCell.appendChild(deleteButton);
});
}

Loading