Cape Town | 2026-ITP-Jan | Pretty Taruvinga | Sprint 2 | Book Library#468

Closed

Pretty548 wants to merge 24 commits intoCodeYourFuture:mainfrom

Pretty548 commented Apr 21, 2026 •

edited

Loading

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Completed unit testing exercises for Roman numerals, factorial, averages, car sales, largest number, and remove vowels
Added and updated Jest test files
Fixed Jest configuration to run only .test.js files
Fixed removeVowels import issue
Resolved CommonJS module export/import issues
Reduced false failures caused by implementation files being treated as test suites

Pretty Taruvinga added 24 commits

April 21, 2026 18:45


          Fix render loop syntax error and display books on load

37f61c7

Fix submit function to add books correctly
Fix author field bug and read status logic
Fix delete button functionality
Add form validation for missing author input


          Add object destructuring to introduceYourself function

1279f89


          Filter Gryffindor members and teachers with pets using destructuring

af758d3


          Print takeout receipt using object destructuring

70dad6b


          Implement ASCII cowsay CLI with default fallback message

1c1a717


          Add readline prompt and default fallback to cowsay

433d3bb


          Fix cowsay CLI argument handling and syntax errors"

6f81c61


          Add convertToNewRoman function for modern Roman numeral conversion

47f2094


          Add initial test for converting 1 to I

fb4cd7e


          Implement minimal convertToOldRoman function to pass first test

2689f12


          Add initial test for converting 1 to old Roman numeral I

a2d2a04


          Implement sales function to total car prices by make

003029f


          Implement factorial function using loop

0b5add5


          Implement factorial function using loop

9b628c5


          Implement average function excluding strings from calculation

f902079


          Add test for largest number function and verify array is unchanged

4d7dcec


          Add test for removing vowels from all words in array

09b94c5


          Implement removeVowels function to remove lowercase vowels from word

1ae0ec8


          Fix HTML validation errors and add language attribute"

c43aa61


          Clean up HTML validator issues"

2c80a9b


          Refactor book library code and address review feedback"

851d249


          Add readline prompt to interactive cowsay solution

d0a6c0a


          Set up HTML structure for mini-weather app

b67a1fe


          Remove duplicate opacity declaration in thumbnail styles

4c83be7

github-actions Bot commented Apr 21, 2026

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions Bot commented Apr 21, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^debugging/book-library/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

3 similar comments

github-actions Bot commented Apr 21, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^debugging/book-library/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions Bot commented Apr 21, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^debugging/book-library/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions Bot commented Apr 21, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^debugging/book-library/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Pretty548 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet