Skip to content

Cape Town | 2026-ITP-Jan | Pretty Taruvinga | Sprint 2 | Book Library#469

Closed
Pretty548 wants to merge 29 commits intoCodeYourFuture:mainfrom
Pretty548:book-library-debugging
Closed

Cape Town | 2026-ITP-Jan | Pretty Taruvinga | Sprint 2 | Book Library#469
Pretty548 wants to merge 29 commits intoCodeYourFuture:mainfrom
Pretty548:book-library-debugging

Conversation

@Pretty548
Copy link
Copy Markdown

@Pretty548 Pretty548 commented Apr 21, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Fixed syntax errors preventing books from rendering
  • Fixed add book functionality and author field bug
  • Fixed read status logic and delete button functionality
  • Added HTML validation fixes and corrected input types
  • Improved form input validation and preprocessing
  • Refactored variable names and render logic
  • Replaced innerHTML with textContent
  • Simplified read status logic and improved delete handling
  • Removed unnecessary code and updated const/let usage
  • Improved form styling and button spacing

Pretty Taruvinga added 24 commits April 21, 2026 18:45
Fix render loop syntax error and display books on load
37f61c7 
Fix submit function to add books correctly
Fix author field bug and read status logic
Fix delete button functionality
Add form validation for missing author input
Add object destructuring to introduceYourself function
1279f89
Filter Gryffindor members and teachers with pets using destructuring
af758d3
Print takeout receipt using object destructuring
70dad6b
Implement ASCII cowsay CLI with default fallback message
1c1a717
Add readline prompt and default fallback to cowsay
433d3bb
Fix cowsay CLI argument handling and syntax errors"
6f81c61
Add convertToNewRoman function for modern Roman numeral conversion
47f2094
Add initial test for converting 1 to I
fb4cd7e
Implement minimal convertToOldRoman function to pass first test
2689f12
Add initial test for converting 1 to old Roman numeral I
a2d2a04
Implement sales function to total car prices by make
003029f
Implement factorial function using loop
0b5add5
Implement factorial function using loop
9b628c5
Implement average function excluding strings from calculation
f902079
Add test for largest number function and verify array is unchanged
4d7dcec
Add test for removing vowels from all words in array
09b94c5
Implement removeVowels function to remove lowercase vowels from word
1ae0ec8
Fix HTML validation errors and add language attribute"
c43aa61
Clean up HTML validator issues"
2c80a9b
Refactor book library code and address review feedback"
851d249
Add readline prompt to interactive cowsay solution
d0a6c0a
Set up HTML structure for mini-weather app
b67a1fe
Remove duplicate opacity declaration in thumbnail styles
4c83be7
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^debugging/book-library/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

2 similar comments
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^debugging/book-library/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^debugging/book-library/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Fix render loop syntax error and display books on load
a9e36f6 
Fix submit function to add books correctly
Fix author field bug and read status logic
Fix delete button functionality
Add form validation for missing author input
Pretty Taruvinga added 4 commits April 22, 2026 13:31
Fix render loop syntax error and display books on load
6293c2f 
Fix submit function to add books correctly
Fix author field bug and read status logic
Fix delete button functionality
Add form validation for missing author input
Fix render loop syntax error and display books on load
7bf8599 
Fix submit function to add books correctly
Fix author field bug and read status logic
Fix delete button functionality
Add form validation for missing author input
Fix HTML validation errors and add language attribute"
5f71e0c
Refactor book library code and address review feedback"
45243e4
@Pretty548 Pretty548 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 22, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^debugging/book-library/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 22, 2026
@Pretty548 Pretty548 closed this Apr 22, 2026
@Pretty548 Pretty548 deleted the book-library-debugging branch April 22, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Pretty548