London | 26 ITP January | Mouawia Elkhalifa | Sprint 3 | Alarm Clock#1087
Open
MouawiaElkhalifa wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
London | 26 ITP January | Mouawia Elkhalifa | Sprint 3 | Alarm Clock#1087MouawiaElkhalifa wants to merge 2 commits intoCodeYourFuture:mainfrom
MouawiaElkhalifa wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
MouawiaElkhalifa
added
the
Needs Review
MouawiaElkhalifa
force-pushed
the
sprint-3
branch
from
a6bbeae to
debc327
Compare
cjyuan
reviewed
Apr 5, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
-
Code works fine if a user only clicks the "Set Alarm" button once.
However, if the user enters a time and then clicks the "Set Alarm" button multiple times, the countdown clock will not display properly.
Can you fix the issue? -
You missed updating
index.htmlaccording to an instruction inreadme.md.
Sprint-3/alarmclock/alarmclock.js
Outdated
| @@ -1,4 +1,30 @@ | |||
| function setAlarm() {} | |||
| function setAlarm() { | |||
| let timeRemaining = document.getElementById("alarmSet").value; | |||
Contributor
There was a problem hiding this comment.
Some unusual input values can make your app behave abnormally. Can you add code to sanitise the input?
Author
There was a problem hiding this comment.
thanks! I have updated the code to sanitize the input using parseInt() and isNaN() to handle unusual values.
cjyuan
added
Reviewed
MouawiaElkhalifa
added
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
In this PR, I have completed the Alarm Clock assignment for Sprint 3.