Manchester | 26-ITP-Jan | Mehroz Munir | Sprint 3 | Practice TDD Coursework by MehrozMunir · Pull Request #1147 · CodeYourFuture/Module-Structuring-and-Testing-Data

MehrozMunir · 2026-03-03T16:52:50Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Created maximum possible categorical test cases and then corrected the implementation so that all the test cases be passed.

kyle-tightest · 2026-03-12T19:30:55Z

Sprint-3/2-practice-tdd/count.js

@@ -1,5 +1,8 @@
 function countChar(stringOfCharacters, findCharacter) {
-  return 5
+  if (findCharacter === "")


good validation checking. is there perhaps another parameter here that could result in the same output?

Yes I think that I can check the length of the findCharacter here and if that is 0 I would return 0;

if (findCharacter.length === 0) return 0;

And I think that is a better validation than checking if string is empty. I have replaced this in my code now.

Thanks

While that is true I was actually referring to something else.
Look at the method again and see is there perhaps another parameter here that could result in the same output?

oh yes. Actually, if stringOfCharacters.length === 0, I am expecting the same result. I have added it to my code now.

@MehrozMunir 100% yes! defensive coding is always a good idea

kyle-tightest · 2026-03-12T19:35:59Z

Sprint-3/2-practice-tdd/count.js

+  if (findCharacter === "")
+    return 0;
+  else
+    return stringOfCharacters.split(findCharacter).length -1;


interesting use of split to solve this question, it works perfectly.
how did you think to use split?

When I was thinking about the solutions how can i count the number of characters in a given string. The first thing came to my mind was the use of some loop to go through each character of string and compare it with the character i am looking for and add 1 to your count.

But, then I realized that I can solve it more efficiently without using loop with the use of split method as through split I can get an array of strings separated by character i am looking for in the separater parameter.

So, if I have five occurences of my character in the string, it will return my an array of size 6 that would be strings separated by that character including the empty strings.

Very good, nice innovative solution

kyle-tightest · 2026-03-12T19:36:44Z

Sprint-3/2-practice-tdd/get-ordinal-number.js

+  let numberString = String(num);
+  lastTwoCharactersNumberString = numberString.slice(-2);
+  lastCharacterNumberString = numberString.slice(-1);
+  if(lastTwoCharactersNumberString === "11")


please check your formatting in this file.
make sure it follows the style guide and its consistent so that its easily readable and maintainable

I am sorry my mistake. I had installed prettier for formatting, but did not enable it in the settings as the default formatter and use it on save. I have done it now. And it looks much better.

Thank you.

kyle-tightest · 2026-03-12T19:38:09Z

Sprint-3/2-practice-tdd/repeat-str.js

-function repeatStr() {
-  return "hellohellohello";
+function repeatStr(str, count) {
+  try{


please check your formatting in this file.
make sure it follows the style guide and its consistent so that its easily readable and maintainable

kyle-tightest · 2026-03-12T19:39:05Z

Sprint-3/2-practice-tdd/repeat-str.js

+    else
+    return str.repeat(count);
+  }
+  catch(e){


why are you wrapping this in a try catch?

I was wrapping it because i was catching the thrown error in the catch block and send the error message string back so that I will be able to compare this string in my test file and would know that the error actually is being thrown.

But, I just have learned about the better way how can I test errors thrown in my test file while I was working on a different part of this module. And for that I don't need try catch block here. I have implement this change in the code.

Thanks.

Okay awesome.
Yes there are definitely use cases for "try catch" but its generally not good practice to do "try {} catch (Exception e)" as this treats all exceptions equally and will result in the same behaviour regardless of the type/severity of the exception. it is better to be more explicit with errors and know exactly how you are handling each error. More effort but very worth it when you are trying to debug an issue and all you see is "exception was thrown"

Yes, thank you for the advice. I totally agree with that. I have updated the error message now.

Thanks.

2-practice-tdd completed

d6a54b8

MehrozMunir added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Mar 3, 2026

kyle-tightest reviewed Mar 12, 2026

View reviewed changes

kyle-tightest added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 12, 2026

MehrozMunir added 2 commits March 14, 2026 14:53

worked on the feedback

6936466

error thrown issue is fixed

0b70ab5

MehrozMunir added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 14, 2026

kyle-tightest removed the Reviewed Volunteer to add when completing a review with trainee action still to take. label Mar 16, 2026

refactoring of code after the feedback

87eed81

MehrozMunir mentioned this pull request Mar 16, 2026

26-ITP-Jan | Structuring and testing data | Mehroz Munir MehrozMunir/My-Coursework-Planner#25

Open

kyle-tightest added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 17, 2026

kyle-tightest approved these changes Mar 17, 2026

View reviewed changes

Uh oh!

Conversation

MehrozMunir commented Mar 3, 2026

Learners, PR Template

Changelist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MehrozMunir Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MehrozMunir Mar 16, 2026 •

edited

Loading