London | 26-ITP-Jan | Carlos Abreu | Sprint 3 | Refactoring Dead Code #1172
London | 26-ITP-Jan | Carlos Abreu | Sprint 3 | Refactoring Dead Code #1172carlosyabreu wants to merge 5 commits intoCodeYourFuture:mainfrom
Conversation
SlideGauge
left a comment
There was a problem hiding this comment.
Dead code removed correctly, my main concern is the way how code is organized: we have old code in comments and new code. Could you just remove the dead code, as the task asks?
.gitignore
Outdated
| .DS_Store | ||
| .vscode | ||
| **/.DS_Store No newline at end of file | ||
| *package.json |
There was a problem hiding this comment.
package.json and package-lock.json should not be in gitignore
Also, will *package.json ignore only one type of filename?
There was a problem hiding this comment.
Evening @SlideGauge
Thank for the feedback.
I remove the old code on the implementation and made it more cleaner.
Thanks for info not to include package.json and package-lock.json file in .gitignore.
I didn't know that.
About the last question, package.json when put in .gitignore fiel will ignore any files that end with package.json. In other words all files () with suffixes package.json
Learners, PR Template
Self checklist
Changelist
PR for Sprint-3 of Refactoring dead code