Skip to content

London | 26-ITP-Jan | Carlos Abreu | Sprint 3 | Refactoring Dead Code #1172

Open
carlosyabreu wants to merge 5 commits intoCodeYourFuture:mainfrom
carlosyabreu:coursework/sprint-3-dead-code
Open

London | 26-ITP-Jan | Carlos Abreu | Sprint 3 | Refactoring Dead Code #1172
carlosyabreu wants to merge 5 commits intoCodeYourFuture:mainfrom
carlosyabreu:coursework/sprint-3-dead-code

Conversation

@carlosyabreu
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

PR for Sprint-3 of Refactoring dead code

@carlosyabreu carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 4, 2026
Copy link

@SlideGauge SlideGauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code removed correctly, my main concern is the way how code is organized: we have old code in comments and new code. Could you just remove the dead code, as the task asks?

.gitignore Outdated
.DS_Store
.vscode
**/.DS_Store No newline at end of file
*package.json

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json and package-lock.json should not be in gitignore
Also, will *package.json ignore only one type of filename?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Evening @SlideGauge
Thank for the feedback.
I remove the old code on the implementation and made it more cleaner.
Thanks for info not to include package.json and package-lock.json file in .gitignore.
I didn't know that.
About the last question, package.json when put in .gitignore fiel will ignore any files that end with package.json. In other words all files () with suffixes package.json

@SlideGauge SlideGauge added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 14, 2026
@carlosyabreu carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants