generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 337
Sheffield | ITP-Jan-26 | Hayriye Saricicek | Sprint 3 | practice tdd #1237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mshayriyesaricicek
wants to merge
17
commits into
CodeYourFuture:main
Choose a base branch
from
mshayriyesaricicek:Sprint-3-practice-tdd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
32407f9
Update .gitignore to include .vscode directory
mshayriyesaricicek 3f7a169
wrote function and tests for count
mshayriyesaricicek 2c8e627
wrote function and tests for ordinal numbers
mshayriyesaricicek 3217cc5
tests and function to repeat string
mshayriyesaricicek 7f76795
Grouped tests together for count.test
mshayriyesaricicek 01e4e00
added tests and renamed variable
mshayriyesaricicek 7604204
updated description
mshayriyesaricicek ebfb090
made descriptions more informative
mshayriyesaricicek e4de3c6
added curly bracket
mshayriyesaricicek 11c8346
Corrected syntax errors and indentation
mshayriyesaricicek e947150
removed redundant checks and added check for negative values
mshayriyesaricicek f55e9b5
made variables into camelCase and shortened the code for checking 11,…
mshayriyesaricicek ebe2c5d
updated description of appending th
mshayriyesaricicek daec403
updated description for clarity
mshayriyesaricicek 514a9da
Changed description for the append
mshayriyesaricicek 1efb9a9
clarified
mshayriyesaricicek 659e4b2
changed test description
mshayriyesaricicek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| node_modules | ||
| .DS_Store | ||
| .vscode | ||
| **/.DS_Store | ||
| .vscode/ | ||
| **/.DS_Store |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,12 @@ | ||
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| let count = 0; | ||
| for (let char of stringOfCharacters) { | ||
| if (char === findCharacter) { | ||
| count++; | ||
| } | ||
| } | ||
|
|
||
| return count; | ||
| } | ||
|
|
||
| module.exports = countChar; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,20 @@ | ||
| function getOrdinalNumber(num) { | ||
| return "1st"; | ||
| // Check if input is a number | ||
| if (!Number.isInteger(num) || !Number.isFinite(num) || num <= 0) { | ||
| throw new Error("Input must be a valid number"); | ||
| } | ||
|
|
||
| const lastNum = num % 10; // checks what last number is | ||
| const last2Num = num % 100; // checks what last two numbers are, needed to check for 11 | ||
|
|
||
| if (last2Num >= 11 && last2Num <= 13) { | ||
| return num + "th"; | ||
| } | ||
| if (lastNum === 1) return num + "st"; | ||
| if (lastNum === 2) return num + "nd"; | ||
| if (lastNum === 3) return num + "rd"; | ||
|
|
||
| return num + "th"; | ||
| } | ||
|
|
||
| module.exports = getOrdinalNumber; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,13 @@ | ||
| function repeatStr() { | ||
| return "hellohellohello"; | ||
| function repeatStr(str, count) { | ||
| if (count < 0) { | ||
| throw new Error("Count must be positive"); | ||
| } | ||
|
|
||
| if (count === 0) { | ||
| return " "; | ||
| } | ||
|
|
||
| return str.repeat(count); | ||
| } | ||
|
|
||
| module.exports = repeatStr; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Number.isFinite()is also redundantGood thinking about rejecting negative numbers. In some context such as in math, the ordinal number of
0is0th.