Sheffield | 26-ITP-Jan | Mahammad Osman | Sprint 3 | Practice TDD#1262
Sheffield | 26-ITP-Jan | Mahammad Osman | Sprint 3 | Practice TDD#1262Darkidd77 wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
Darkidd77
added
the
Needs Review
| // When the function is called with these inputs, | ||
| // Then it should return 0, indicating that no occurrences of `char` were found. | ||
|
|
||
| test("should show no occurrences of a character", () => { |
There was a problem hiding this comment.
It's probably clearer to state what the function "should return ... when ..." than the current description.
There was a problem hiding this comment.
Yes, Noted, I edited it, I see it's clearer message now. Thank you
| // 1. Handle the 11, 12, 13 exceptions first | ||
| if (num === 11 || num === 12 || num === 13) { | ||
| return num + "th"; | ||
| } |
There was a problem hiding this comment.
The rule apply to all numbers ending with 11, 12, and 13 (not just to those three numbers).
There was a problem hiding this comment.
Updated the code to solve all number that ends with 11, 12, or 13. Thank you
| // Case 5: Numbers ending with 0, 4, 5, 6, 7, 8, or 9 (but not 10) | ||
| // When the number ends with 0, 4, 5, 6, 7, 8, or 9, except those ending with 10, | ||
| // Then the function should return a string by appending "th" to the number. | ||
| test("should append 'th' for numbers ending with 0, 4-9, except those ending with 10", () => { |
There was a problem hiding this comment.
This description is giving mixed info. Should 110 be converted to 110th or not?
There was a problem hiding this comment.
Yes I realised I treated 10 as an exception but it's not and part of the rule, I've updated the test message and added a case.
cjyuan
added
Reviewed
…ty and consistency
| // Case 5: Numbers ending with 0, 4, 5, 6, 7, 8, or 9 (but not 10) | ||
| // When the number ends with 0, 4, 5, 6, 7, 8, or 9, except those ending with 10, | ||
| // Then the function should return a string by appending "th" to the number. | ||
| test("should return 'th' for numbers ending in 0 or 4 through 9", () => { |
There was a problem hiding this comment.
The comments on line 50-53 still showing contradicting info.
Do you still need all these comments now that you have rephrase them, in a concise way, in the test description?
cjyuan
added
Complete
2 participants
Learners, PR Template
Self checklist
Changelist
I used a professional approach called TDD (Test-Driven Development), which means I wrote my tests before writing any code. I built three main tools: a character counter, a string repeater, and an ordinal number generator (like turning "1" into "1st").