fix: resolve picomatch version at 2.3.2 in yarn.lock#3301
fix: resolve picomatch version at 2.3.2 in yarn.lock#3301LinKCoding wants to merge 7 commits intomainfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit 398a628 ☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3301 +/- ##
=======================================
Coverage 89.88% 89.88%
=======================================
Files 377 377
Lines 5593 5593
Branches 1779 1780 +1
=======================================
Hits 5027 5027
Misses 558 558
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| version: 2.3.1 | ||
| resolution: "picomatch@npm:2.3.1" | ||
| checksum: 10c0/26c02b8d06f03206fc2ab8d16f19960f2ff9e81a658f831ecb656d8f17d9edc799e8364b1f4a7873e89d9702dff96204be0fa26fe4181f6843f040f819dac4be | ||
| version: 2.3.2 |
There was a problem hiding this comment.
This was really what we were after
|
📬 Published Alpha Packages:
|
|
🚀 Styleguide deploy preview ready! Preview URL: https://69d3dae0a7724a3bed3e9e1b--gamut-preview.netlify.app |
dreamwasp
left a comment
There was a problem hiding this comment.
this is something that is happening on main too but it'd be nice if this gracefully dealt with file names with spaces -
✔ Backed up original state in git stash (99aac6a41)
⚠ Running tasks for staged files...
❯ .lintstagedrc.mjs — 1 file
❯ * — 1 file
✖ node_modules/@codecademy/eslint-config/bin/eslint-fix.js /Users/cass/code/cc/gamut/packages/styleguide/src/lib/Meta/ESLint rules.mdx [FAILED]
◼ nx format:write --files /Users/cass/code/cc/gamut/packages/styleguide/src/lib/Meta/ESLint rules.mdx
↓ Skipped because of errors from tasks.
✔ Reverting to original state because of errors...
✔ Cleaning up temporary files...
✖ node_modules/@codecademy/eslint-config/bin/eslint-fix.js /Users/cass/code/cc/gamut/packages/styleguide/src/lib/Meta/ESLint rules.mdx:
/Users/cass/code/cc/gamut/node_modules/eslint/lib/cli-engine/file-enumerator.js:320
throw new NoFilesFoundError(
^
NoFilesFoundError: No files matching '/Users/cass/code/cc/gamut/packages/styleguide/src/lib/Meta/ESLint' were found.
Overview
Picomatch version 2.3.1 has a security vulnerability (see: https://app.snyk.io/org/codecademy/project/c51d48f7-252a-44c3-96bb-67f3b77d50a6#issue-SNYK-JS-PICOMATCH-15765511)
This sets the version resolution for picomatch in yarn.lock to be 2.3.2.
PR Checklist
Testing Instructions
Don't make me tap the sign.
PR Links and Envs
N/A