Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-LODASH-15869625 - https://snyk.io/vuln/SNYK-JS-LODASH-15869619
|
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 82508f3a03
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "@codecademy/gamut-patterns": "0.1.0", | ||
| "@codecademy/gamut-styles": "1.1.3", | ||
| "@codecademy/variance": "0.1.0", |
There was a problem hiding this comment.
Keep internal workspace dependency versions consistent
These pins downgrade @codecademy/gamut to very old internal package versions (0.1.0/1.1.3) that no longer match the workspace package versions in this repo (packages/gamut-patterns/package.json:4, packages/gamut-styles/package.json:4, packages/variance/package.json:4). Because the versions are exact, Yarn will resolve external registry packages instead of local workspaces, so this package can build and run against a different API surface than the rest of the monorepo.
Useful? React with 👍 / 👎.
| "html-to-react": "^1.6.0", | ||
| "invariant": "^2.2.4", | ||
| "lodash": "^4.17.23", | ||
| "lodash": "^4.18.1", |
There was a problem hiding this comment.
Commit lockfile updates with dependency version changes
This dependency change is not accompanied by a yarn.lock update, but CI installs through .github/actions/yarn/action.yml:16 using yarn install --immutable. Per yarn install --help, immutable mode exits with an error if the lockfile would be modified, so this commit will fail install/CI until the lockfile is regenerated and committed.
Useful? React with 👍 / 👎.
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
packages/gamut/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-LODASH-15869625
SNYK-JS-LODASH-15869619
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Prototype Pollution
🦉 Arbitrary Code Injection