Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-LODASH-15869625 - https://snyk.io/vuln/SNYK-JS-LODASH-15869619
|
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 213a428332
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "author": "Codecademy Engineering <dev@codecademy.com>", | ||
| "dependencies": { | ||
| "@codecademy/gamut-styles": "17.13.1", | ||
| "@codecademy/gamut-styles": "1.1.3", |
There was a problem hiding this comment.
Keep gamut-styles on the workspace-major version
Changing @codecademy/gamut-styles from 17.13.1 to 1.1.3 downgrades @codecademy/gamut-tests to a much older package line and breaks alignment with the in-repo styles package (packages/gamut-styles/package.json is 17.13.1). This introduces a high risk of API drift and test/build breakage because gamut-tests will no longer consume the same styles version used across the monorepo.
Useful? React with 👍 / 👎.
| "@codecademy/gamut-styles": "1.1.3", | ||
| "component-test-setup": "*", | ||
| "lodash": "^4.17.23" | ||
| "lodash": "^4.18.1" |
There was a problem hiding this comment.
Regenerate lockfile after manifest dependency changes
This commit changes dependency versions in package.json but does not update yarn.lock. The CI bootstrap action at .github/actions/yarn/action.yml runs yarn install --immutable, and Yarn help explicitly says --immutable aborts when the lockfile would be modified, so workflows that install dependencies through this action will fail until the lockfile is regenerated and committed.
Useful? React with 👍 / 👎.
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
packages/gamut-tests/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-LODASH-15869625
SNYK-JS-LODASH-15869619
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Prototype Pollution
🦉 Arbitrary Code Injection