Skip to content

[Snyk] Fix for 2 vulnerabilities#3308

Closed
codecademydev wants to merge 1 commit intomainfrom
snyk-fix-7d8e6b32d659ae701d337547615bf8df
Closed

[Snyk] Fix for 2 vulnerabilities#3308
codecademydev wants to merge 1 commit intomainfrom
snyk-fix-7d8e6b32d659ae701d337547615bf8df

Conversation

@codecademydev
Copy link
Copy Markdown
Collaborator

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • packages/gamut-tests/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Arbitrary Code Injection
SNYK-JS-LODASH-15869625
  716  
medium severity Prototype Pollution
SNYK-JS-LODASH-15869619
  631  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Prototype Pollution
🦉 Arbitrary Code Injection

@codecademydev codecademydev requested a review from a team as a code owner April 2, 2026 06:54
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 213a428332

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

"author": "Codecademy Engineering <dev@codecademy.com>",
"dependencies": {
"@codecademy/gamut-styles": "17.13.1",
"@codecademy/gamut-styles": "1.1.3",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep gamut-styles on the workspace-major version

Changing @codecademy/gamut-styles from 17.13.1 to 1.1.3 downgrades @codecademy/gamut-tests to a much older package line and breaks alignment with the in-repo styles package (packages/gamut-styles/package.json is 17.13.1). This introduces a high risk of API drift and test/build breakage because gamut-tests will no longer consume the same styles version used across the monorepo.

Useful? React with 👍 / 👎.

Comment on lines +7 to +9
"@codecademy/gamut-styles": "1.1.3",
"component-test-setup": "*",
"lodash": "^4.17.23"
"lodash": "^4.18.1"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Regenerate lockfile after manifest dependency changes

This commit changes dependency versions in package.json but does not update yarn.lock. The CI bootstrap action at .github/actions/yarn/action.yml runs yarn install --immutable, and Yarn help explicitly says --immutable aborts when the lockfile would be modified, so workflows that install dependencies through this action will fail until the lockfile is regenerated and committed.

Useful? React with 👍 / 👎.

@jakemhiller jakemhiller closed this Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants