Skip to content

chore(PopoverContainer): clean up isRTL hook#3317

Draft
LinKCoding wants to merge 2 commits intocass-gmt-1601from
kl-gmt-1598-popover-rtl
Draft

chore(PopoverContainer): clean up isRTL hook#3317
LinKCoding wants to merge 2 commits intocass-gmt-1601from
kl-gmt-1598-popover-rtl

Conversation

@LinKCoding
Copy link
Copy Markdown
Contributor

@LinKCoding LinKCoding commented Apr 3, 2026

Overview

PopoverContainer has its own isRTL useEffect, but this logic now lives in the useDirectionIsRTL hook.
Cleaning up code to use the newer hook.

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GMT-1598
  • Version plan added/updated (or not needed)
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. Go to story X
  2. Do something
  3. Do that something in dark mode
  4. Check it with VO
  5. Finish and do a celebratory dance

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@LinKCoding LinKCoding changed the base branch from main to cass-gmt-1601 April 3, 2026 18:00
@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Apr 3, 2026

View your CI Pipeline Execution ↗ for commit 8bb855f


☁️ Nx Cloud last updated this comment at 2026-04-03 18:09:13 UTC

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

@codecademydev
Copy link
Copy Markdown
Collaborator

📬 Published Alpha Packages:

Package Version npm Diff
@codecademy/gamut 68.2.3-alpha.186893.0 npm diff
@codecademy/gamut-icons 9.57.3-alpha.186893.0 npm diff
@codecademy/gamut-illustrations 0.58.10-alpha.186893.0 npm diff
@codecademy/gamut-kit 0.6.593-alpha.186893.0 npm diff
@codecademy/gamut-patterns 0.10.29-alpha.186893.0 npm diff
@codecademy/gamut-styles 17.13.2-alpha.186893.0 npm diff
@codecademy/gamut-tests 5.3.4-alpha.186893.0 npm diff
@codecademy/variance 0.26.2-alpha.186893.0 npm diff
eslint-plugin-gamut 2.4.4-alpha.186893.0 npm diff

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants