[8.1] Add functional test for assertBrowserHistoryIsNotOnLastPage#59
Merged
TavoNiievez merged 1 commit intoJun 26, 2026
Merged
Conversation
Covers the last untested Symfony-inherited browser-history assertion from module-symfony#240. Uses the public moveBack() step to position the browser history off the last page.
ee78d8e to
03e2424
Compare
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the one missing functional test for the Symfony-inherited browser-history assertions introduced in Codeception/module-symfony#240 (
assertBrowserHistoryIsNotOnLastPage). The sibling assertions (IsNotOnFirstPage,IsOnFirstPage,IsOnLastPage) were already covered by #45–#48; this one was omitted because no public step could position the browser history off the last page.The assertion requires
symfony/browser-kit >= 7.4, so it applies to the7.4and8.1branches only.Depends on Codeception/lib-innerbrowser#87
On released
lib-innerbrowser,moveBack()replays the previous request withchangeHistory = true, which re-appends to the history and leaves the pointer on the last page — so this test only passes once Codeception/lib-innerbrowser#87 (move the history pointer instead of appending) is merged and released. CI here will be red until then.