Escaped submenu toggle aria-label attributes#4546
Open
girishpanchal30 wants to merge 1 commit into
Open
Conversation
girishpanchal30
added
the
pr-checklist-skip
pirate-bot
added
the
pr-checklist-complete
There was a problem hiding this comment.
Pull request overview
Escapes dynamic mobile submenu labels to prevent malformed HTML attributes and XSS risks.
Changes:
- Builds the toggle label separately.
- Applies attribute-context escaping before rendering.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| $caret .= $caret_pictogram; | ||
| $caret .= '</button>'; | ||
| $toggle_aria_label = __( 'Toggle', 'neve' ) . ' ' . wp_filter_nohtml_kses( $title ); | ||
| $caret = '<button ' . $expanded . ' type="button" class="caret-wrap navbar-toggle ' . esc_attr( (string) $item->menu_order ) . ' ' . esc_attr( $additional_class ) . '" style="' . esc_attr( $caret_wrap_css ) . '" aria-label="' . esc_attr( $toggle_aria_label ) . '">'; |
Collaborator
Soare-Robert-Daniel
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Escaped the title for the toggle button in the navigation menu to ensure that it is safe for use in HTML attributes. This prevents potential security vulnerabilities such as XSS attacks.
Check before Pull Request is ready:
Closes #4503