feat: add transactional plan and apply engine#5
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb538bd7f3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| } | ||
|
|
||
| $sortedOperations = @($operations.ToArray() | Sort-Object { $_.id }) |
There was a problem hiding this comment.
On a clean workstation where Node/npm are absent, sorting every operation by ID places tool:claude and tool:codex before tool:node and tool:npm. Apply therefore invokes npm install -g ... before npm exists, fails on the first npm-backed tool, and never reaches the Node installation. Preserve dependency-aware/manifest ordering or explicitly model tool dependencies.
Useful? React with 👍 / 👎.
| $installer = @($resource.definition.installers | Where-Object kind -ne "manual" | Select-Object -First 1) | ||
| $satisfied = $actual.Count -gt 0 -and $actual[0].status -eq "installed" | ||
| $command = if ($installer.Count -gt 0) { "$($installer[0].kind) install $($installer[0].id)" } else { "manual" } | ||
| $source = if ($installer.Count -gt 0) { "$($installer[0].kind):$($installer[0].id)" } else { "manual" } |
There was a problem hiding this comment.
When a required tool has no non-manual installer, this creates an update operation with source manual; the core/full profiles include npm with no installers and wsl with only a manual installer. If either is missing during inventory, apply reaches the executor's unsupported-adapter error and the setup can never complete, even if installing Node earlier made npm available after planning. Manual tools need a non-failing guidance/skip operation or must be re-inventoried before execution.
Useful? React with 👍 / 👎.
| $satisfied = $actual.Count -gt 0 -and $actual[0].status -eq "synchronized" | ||
| $present = $actual.Count -gt 0 -and $actual[0].status -in @("present", "behind", "synchronized") |
There was a problem hiding this comment.
For an existing clean checkout whose cached origin/<branch> still equals HEAD but whose actual remote has advanced, inventory reports synchronized because Get-CasRepositorySafetyStatus only compares against the local remote-tracking ref. This line then emits a skip, so upgrade never runs the executor's fetch and permanently misses upstream changes until something else fetches them.
Useful? React with 👍 / 👎.
| if ($Operation.action -eq "create") { | ||
| & git clone $Operation.source $Operation.target | ||
| } |
There was a problem hiding this comment.
During setup -Apply against a fresh root, the apply engine creates only the config, state, and log directories; it never creates <root>/<reposRoot>. The first repository create operation therefore asks Git to clone into a target whose parent directory does not exist, causing fresh-workstation setup to fail before any repository is installed.
Useful? React with 👍 / 👎.
| switch ($resource.category) { | ||
| "tools" { |
There was a problem hiding this comment.
The resolved desired state contains tools, repos, services, clients, skills, and workspaces, but this switch handles only tools and repos and silently drops every other category. Because setup.ps1 and upgrade.ps1 now exclusively use this operation engine, -Apply no longer calls New-CasClientConfigs, so it can report success without generating the required MCP client or runtime configuration.
Useful? React with 👍 / 👎.
2 participants
Summary
Validation