Regenerate shapely.pot after the text domain unification - #347
Merged
Conversation
The POT was generated in the build commit, before the commit that moved the vendored Epsilon framework's 114 strings from the 'epsilon-framework' domain onto 'shapely'. WP-CLI filters by domain, so the template shipped in 1.2.20 was built against the state before that change. Result: 238 strings covering 2 files under inc/libraries/, where the source now has 324 strings across 21. Translators working from the bundled template would not see the 86 admin and customizer strings the unification made translatable for the first time. No functional impact -- the strings render in English either way, and translate.wordpress.org scans the source rather than the bundled POT -- but the shipped template should match the code. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up to #346, caught while verifying the release.
The POT was regenerated in the build commit — but the text-domain unification landed in a later commit, and WP-CLI filters
make-potby domain. So the template shipped in 1.2.20 was built against the pre-unification state.The 86 missing entries are the admin and customizer strings that the unification made translatable for the first time — previously they sat under
epsilon-framework, a domain WordPress.org language packs never covered.No functional impact. Those strings render in English either way, and translate.wordpress.org scans source rather than the bundled POT, so GlotPress already has them. This just makes the shipped template match the code for anyone translating offline.
Verified:
npm run i18n:checkstill passes — 436 gettext calls, singleshapelydomain.🤖 Generated with Claude Code