Skip to content

move images for benchmarking-mortgage-underwriting-agents to correct dir#71

Merged
Alex-XJK merged 1 commit into
Columbia-DAP-Lab:mainfrom
mtoles:main
Mar 16, 2026
Merged

move images for benchmarking-mortgage-underwriting-agents to correct dir#71
Alex-XJK merged 1 commit into
Columbia-DAP-Lab:mainfrom
mtoles:main

Conversation

@mtoles
Copy link
Copy Markdown
Contributor

@mtoles mtoles commented Mar 16, 2026

move images for benchmarking-mortgage-underwriting-agents to correct dir

@Alex-XJK Alex-XJK self-assigned this Mar 16, 2026
@Alex-XJK Alex-XJK merged commit 5ddb00d into Columbia-DAP-Lab:main Mar 16, 2026
1 check passed
@Alex-XJK
Copy link
Copy Markdown
Collaborator

This PR has the following two issues:

  1. During the process of moving the image path, only the deletion step was committed by the PR author; as a result, we discovered the images not found issue during my local testing. (Resolved in d5329cd)
  2. Lingering issues from Add benchmarking-mortgage-underwriting-agents blog post #69: Blog-specific style code was incorrectly added to the global file, which could have been resolved with a local style declaration; image references were not implemented as specified in the README; and images were placed in the wrong directory. (Resolved in a33531d)

To minimize back-and-forth, I will assist with the changes locally. However, please note that future PRs that do not follow the README guidelines will be rejected outright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants