Skip to content

Debian13 20260702#14851

Open
a-skr wants to merge 15 commits into
ComplianceAsCode:masterfrom
a-skr:debian13-20260702
Open

Debian13 20260702#14851
a-skr wants to merge 15 commits into
ComplianceAsCode:masterfrom
a-skr:debian13-20260702

Conversation

@a-skr

@a-skr a-skr commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Description:

  • add a debian13 test container
  • update debian13 cis benchmarks
  • add some new rules related to apt configuration
  • add CIS related profiles

@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Jul 2, 2026
@openshift-ci

openshift-ci Bot commented Jul 2, 2026

Copy link
Copy Markdown

Hi @a-skr. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Change in Ansible shell module found.

Please consider using more suitable Ansible module than shell if possible.

@a-skr a-skr force-pushed the debian13-20260702 branch from f6a726b to 97cc46c Compare July 2, 2026 14:02
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Change in Ansible shell module found.

Please consider using more suitable Ansible module than shell if possible.

@Mab879 Mab879 added this to the 0.1.82 milestone Jul 2, 2026

reference: https://www.cisecurity.org/benchmark/debian_linux

title: 'CIS Debian Benchmark for Level 2 - Server'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add also profile for the Level 1 - Server.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

profile for level 1 server is already present thanks to another contributor.

Comment thread controls/cis_debian13.yml Outdated
- l1_server
- l1_workstation
rules:
- var_password_hashing_algorithm_pam=yescrypt

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CIS Benchmark allows both SHA512 and yescrypt. You should create and select value that allows both ciphers, see linux_os/guide/system/accounts/accounts-pam/var_password_hashing_algorithm_pam.var how we did that for RHEL 10.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be fixed with next commits

Comment thread controls/cis_debian13.yml
levels:
- l2_server
- l2_workstation
rules:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing status: field

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be fixed with next commits

Comment thread controls/cis_debian13.yml Outdated
- file_permissions_var_log_gdm
- file_permissions_var_log_gdm3
- file_permissions_var_log_lastlog
- file_permissions_var_log_cloud-init

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file_permissions_var_log_cloud-init appears twice

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be fixed with next commits

Comment thread controls/cis_debian13.yml Outdated
status: automated

- id: 2.1.16
title: Ensure tftp server services are not in use (Automated)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requirement 2.1.16 should be about telnet

2.1.16 Ensure telnet-server services are not in use (Automated)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be fixed in next commits, along with the related rules. That includes updating some template files to handle virtual debian packages properly.

Comment thread controls/cis_debian13.yml Outdated
- l1_server
- l1_workstation
rules:
- sshd_strong_macs=cis_debian12

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest creating a special selector for Debian 13 even if that would have the same value.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be fixed with next commits.

Comment thread controls/cis_debian13.yml Outdated
Comment on lines +1483 to +1484
- id: 3.3.1.
title: Ensure is configured (Automated)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suspicious. Please remove this item.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be fixed with next commits.

Comment thread controls/cis_debian13.yml Outdated
status: automated

- id: 7.1.4
title: Ensure paccess to /etc/group- is configured (Automated)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paccess

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be fixed with next commits.

Comment thread controls/cis_debian13.yml Outdated
status: pending

- id: 3.3.2.1
title: Ensure Ensure net.ipv6.conf.all.forwarding is configured (Automated)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate "Ensure"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be fixed with next commits.

@a-skr a-skr force-pushed the debian13-20260702 branch from 97cc46c to 1cffdf4 Compare July 9, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Used by openshift-ci bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants