Check if user is spring intro member so it returns the right number of directorships#532
Open
charlottegeo wants to merge 2 commits intoComputerScienceHouse:developfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the req_cm function in member.py to check if a user was a spring intro member, and returns 15 (directorships) if they were a spring intro member.
Why
Spring intro members only need 15 directorships to pass spring evals but currently in Conditional it requires 30 for all members because it didn't check if they were a spring intro member.
Test Plan
I added an existing active member to the freshman_eval_data in my local database + set the eval_date to this year's spring intro evals date to make sure that the required number of directorships is set to 15 for spring intro members who passed intro evals.
Env Vars
No
Documentation
I changed the comment at the start of req_cm to reflect that it now gets the number of required directorships based on if the member is on co_op or is a spring intro member who passed intro evals.
Checklist