feature/bug-fixes#1
Conversation
to fix bug with widgets not being able to be defined
…4)' (#143) from feature/true-upload-file-function into feature/bug-fixes Reviewed-on: https://codeberg.org/Conduction/launchpad/pulls/143 Reviewed-by: WilcoLouwerse <wilcolouwerse@noreply.codeberg.org>
| routeName: 'core.Preview.getPreviewByFileId', | ||
| arguments: [ | ||
| 'fileId' => $node->getId(), | ||
| 'x' => 256, |
There was a problem hiding this comment.
🟢 Minor — Preview thumbnail size increased 16× in area
Old path requested 64×64; new path requests 256×256 with a=1 (aspect-preserved). Nextcloud will serve the nearest cached size, but on cold cache this triples per-file preview generation cost. If the files widget renders many rows simultaneously, dashboard load will trigger a burst of preview jobs. Worth confirming the frontend <img> display size is constrained (so the browser downscales cleanly) and that pagination/virtualisation is in place before this lands on large deployments.
WilcoLouwerse
left a comment
WilcoLouwerse
left a comment
There was a problem hiding this comment.
APPROVE — reviewed the 6 new commits since the Codeberg migration (pre-reviewed commits skipped as instructed). The ManifestController DoesNotExistException catch, widgetBridge / registerDashboardWidgets side-effect imports, FilesWidgetService preview-URL emit, and the OSM tile CSP addition all check out on inspection.
One 🟢 minor heads-up on the preview thumbnail size bump: #1 (comment)
3 participants
Heropend na de migratie van Codeberg naar GitHub (2026-07-14).
Origineel, met review-historie: https://codeberg.org/Conduction/launchpad/pulls/141