Skip to content

chore(deps): bump nextcloud-vue to beta.220 (OpenBuild glyph fix) - #2081

Closed
rubenvdlinde wants to merge 1 commit into
developmentfrom
chore/ncvue-beta220-glyph
Closed

chore(deps): bump nextcloud-vue to beta.220 (OpenBuild glyph fix)#2081
rubenvdlinde wants to merge 1 commit into
developmentfrom
chore/ncvue-beta220-glyph

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Bumps @conduction/nextcloud-vue to ^1.0.0-beta.220, picking up the OpenBuild edit-button glyph fix (package/cube → OpenBuild stacked-layers icon), shipped in beta.218.

This app's currently-shipped bundle binds the old cube glyph (confirmed by scanning the built js/ for the path bound to cn-openbuild-edit__glyph), so it needs this bump for its next CI/release build to ship the correct icon.

Dependency-only change — no source edits.

Picks up the OpenBuild edit-button glyph fix (package/cube -> OpenBuild
stacked-layers), shipped in beta.218. This app's bundle still binds the old
cube glyph, so its next CI/release build needs this bump.
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/openregister @ ea225e8

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
composer ✅ 173/173
npm
PHPUnit ⏭️
Newman ⏭️
Playwright ⏭️

Quality workflow — 2026-07-24 15:33 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde

Copy link
Copy Markdown
Contributor Author

⚠️ Two caveats before merging this one (both pre-existing, not introduced here):

1. package-lock.json is NOT updated — npm ci will fail.
The lockfile could not be regenerated because of a pre-existing conflict in package.json:

npm error Override for vue@^2.6 || ^3.0 conflicts with direct dependency

overrides.vue is ^2.7.16 while dependencies.vue is ^2.6 || ^3.0. npm refuses to resolve that, so no lockfile regeneration is possible (with or without this bump). Someone owning this repo should reconcile the two ranges, then refresh the lock. I deliberately did not change the vue range on the foundation repo unilaterally.

2. Unlike the other apps, openregister's js/ is committed (not gitignored).
So this dependency bump alone will not change the shipped icon — the committed bundle still binds the old cube glyph. It needs a rebuild + committed js/ to actually ship the layers icon.

Context: this is part of a fleet-wide bump picking up the OpenBuild edit-button glyph fix (cube → stacked-layers, shipped in nc-vue beta.218). See also ConductionNL/nextcloud-vue#532 for a related vue3-dist packaging defect.

@rubenvdlinde

Copy link
Copy Markdown
Contributor Author

Superseded: origin/development already declares @conduction/nextcloud-vue@^1.0.0-beta.220 with a synced lockfile (concurrent work landed it), and the vue-override conflict noted above is resolved (dependencies.vue now matches overrides.vue). The real remaining work is rebuilding the committed js/ bundle against beta.220 (openregister is the one app whose js/ is tracked, not CI-built) — that will be a separate PR carrying the rebuilt bundle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant