Remove redundant main.yaml CI workflow (fixes covdata failure on main) - GitLab Connector#95
Conversation
main.yaml (name "main ci") ran go-lint + go-test on push to main with a hardcoded go-version: 1.23.x. After baton-admin bumped .versions.yaml/go.mod to go 1.25.2, the 1.23.x runner auto-downloads the newer toolchain and `go test -covermode=count` fails with `go: no such tool "covdata"` — the workflow has been red on every push to main since the bump. The managed Verify workflow already runs lint + test + docs on push to main (and on PRs) via the shared ConductorOne/github-workflows verify.yaml, so main.yaml is fully redundant. 423/478 org connectors have no main.yaml and rely on Verify. Removing it fixes the recurring red and eliminates the drift-prone hardcoded Go version. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Connector PR Review: Remove redundant main.yaml CI workflow (fixes covdata failure on main) - GitLab ConnectorBlocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0 Review SummaryThe full PR diff was scanned for security and correctness. This PR only deletes the legacy Security IssuesNone found. Correctness IssuesNone found. SuggestionsNone. |
|
Closing in favor of #94 (luisina-santos), which was opened first and is more complete — besides removing |
Description
Removes the legacy
.github/workflows/main.yaml("main ci") workflow, which has been failing on every push tomainsince baton-admin bumped the Go version.Problem
main.yamlrango-lint+go-teston push tomainwith a hardcodedgo-version: 1.23.x. After.versions.yaml/go.modmoved togo 1.25.2, the 1.23.x runner sees a newergodirective, auto-downloads the 1.25.2 toolchain, and that toolchain switch breaks the coverage run:The workflow ran green for ~11 months and only started failing after the Go bump — it's stale, not intrinsically broken.
Why remove instead of fix
The managed
Verifyworkflow already runslint+test+docson push tomain(and on PRs) via the sharedConductorOne/github-workflows/verify.yaml, and it reads the Go version fromgo.mod, so it's green.main.yamlis fully redundant withVerify.Reference check across the org: 423 of 478 connectors have no
main.yamlat all and rely onVerifyfor exactly this coverage. Removing it:main,Verify).Scope
.github/workflows/main.yamlonly. No code, dependency, or managed-file changes. No other workflow references it.