fix: report fatal errors in plain print mode - #135
Merged
ananthanandanan merged 2 commits intoJul 20, 2026
Conversation
Capture unrecoverable ErrorEvent messages and write them to stderr when JSON output is disabled. Add a CLI regression test for the silent-error path.
Contributor
|
Merged, thanks, and sorry it sat. The delay was mine: main had moved on, but there were no conflicts, so I updated the branch and merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plain
reigner chat --printdiscarded unrecoverableErrorEventmessages, leaving callers with only exit code 1. This captures the fatal message and writes it to stderr while keeping--jsonoutput unchanged.Fixes #134
Tested with
pytest tests/cli/test_chat.py -qand Ruff check/format.