fix(noema): replace conflicted OIDC envelope repair - #822
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
@opencode-agent address Reconcile this replacement Noema OIDC-envelope repair onto current protected Use a trusted checkout and normally merge exact protected main into this existing replacement branch. Resolve conflicts only by preserving every newer protected-main behavior plus this four-file bounded contract:
Do not force-push, use |
|
Current-main replacement is now PR #834 at exact head |
Replacement purpose
Rebuild the Noema OIDC response-envelope repair from exact protected
main1131b1bbafb24e455fc8619cdf316813e8721861because predecessor PR #820 is conflicted and no longer descends from current protected main. Preserve #820 and its development history unchanged until this replacement proves the same bounded contract.No checks, reviews, approvals, comments, or synthetic merge evidence from #820 transfer to this replacement.
Test-first evidence
ad362b633031d85aa5af0c8b502a583a77f7795a.tests/test_noema_oidc_exchange_contract.py; inheritednoema-review.ymlstill read the nonexistent top-level.token.35b3c20633073a384d681b062120bc8994c75ca6implemented the stable envelope contract without changing reviewer authority.6fc96a7ce37d649f2843768c66826ec30e15e109recorded the failure model, rollback, interoperability boundary, and APA 7 primary references.12f52c50fc1d6aa83278e01ba3d1c28760982999, adding only the authoritative[Unreleased]changelog evidence after the production repair.Any workflow, review, approval, or status from an earlier head is historical only.
Bounded repair
ok: true+ object-valueddatasuccess envelope;data.token, exact target repository identity, non-empty workflow-source metadata, and non-empty expiry metadata;.data.tokenafter the complete envelope validates;docs/doctoring/noema-oidc-exchange-envelope.mdand record the repair underCHANGELOG.md.Current gate state
Exact-head workflows and review surfaces are authoritative only for
12f52c50fc1d6aa83278e01ba3d1c28760982999. Queued, pending, cancelled, skipped-required, absent, failed, predecessor-head, stale-base, status-only, author-only, or synthetic-merge evidence is not acceptance.Keep Draft until the exact final head passes focused and complete central tests, 100% production statement/branch/public-docstring gates, all required security and supply-chain workflows, exact-head automated review, zero unresolved valid findings, qualifying independent non-author approval, and branch protection without bypass.
Supersession boundary
Do not close predecessor #820 merely because this replacement exists. Close #820 as superseded only after this replacement demonstrates successful exact-current-head validation and retains the same bounded four-file effective repair from current protected
main; no #820 evidence transfers.