security: bound archive member enumeration before materialization - #87
Draft
seonghobae wants to merge 3 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This was referenced Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement stack repair
This draft supersedes now-closed conflicted/stale-stack PR #70. It reconstructs the same parser-resource hardening on the exact current replacement predecessor #86 without rebasing, retargeting, force-updating, or rewriting either historical branch.
df267fe522c56a28b6ec7d9679bf5edd710b4200.22d3d66ac3f5ff35b100a4095aa09afb07fa0da1.0f6476ee4f705da7b0cd5fa7120b87dcea5803b6.Immutable RED evidence
Exact-head CI run
31150692931checked out22d3d66ac3f5ff35b100a4095aa09afb07fa0da1with persisted credentials disabled. Package acceptance and Ruff succeeded. Every Python 3.10–3.13 test lane failed at the focused regressions; Python 3.13 reported15 failed, 775 passed.The RED tree proved the exact predecessor still entered
ZipFile/tar parser materialization before enforcing the 10,000-member ceiling and lacked bounded ZIP central-directory, expanded-tar, and extension-header preflight controls.Reconstructed bounded implementation
The exact current tree reapplies the reviewed #70 resource-boundary delta onto #86's later descriptor/path-identity hardening rather than copying the stale branch wholesale.
ZipFileallocatesZipInfoobjects, requiring EOCD/record count/size/offset agreement and enforcing at most 10,000 members;getmembers()materialization;scripts/ciinside the canonical production coverage scope and retains only directly relevant operator/research documentation and[Unreleased]evidence;.githubworkflow, credential, permission, model, network transport, protected ref, publication, signing, attestation, or release authority.Exact-current-head verification
CI run
31151452927checked out exact SHA0f6476ee4f705da7b0cd5fa7120b87dcea5803b6explicitly and succeeded across Python 3.10, 3.11, 3.12, and 3.13 plus wheel/sdist package acceptance. Python 3.13 recorded:790 passed;1,631/1,631statements and558/558branches (100%, zero partial branches);release_evidence.pyat371/371statements and122/122branches;Because this PR remains draft behind #86 → #64 → #62, draft-skipped SAST/Security/review evidence is not acceptance. The organization Security Scan must also be rerun after
ContextualWisdomLab/.github#799integrates; its reviewer prerequisite is.github#813.Remaining gates
Keep this PR draft while predecessor #86 is draft and transitively depends on #64/#62. Before integration require accepted predecessors, exact-current-head applicable SAST and repaired organization Security Scan, completed automated review, qualifying independent non-author approval, zero unresolved valid threads, branch protection, and every repository policy gate. Missing, pending, draft-skipped, stale-head, predecessor-head, synthetic-merge, rate-limited, or fail-open evidence is not acceptance.
Do not merge, auto-merge, release, publish, rebase, retarget, or force-update while draft.