🛡️ Sentinel: [HIGH] Fix SQL Injection vulnerability in ERD Tool

[seonghobae]

🚨 Severity: HIGH
💡 Vulnerability: ERD 도구의 DDL 생성 시 컬럼 타입에 대한 검증이 없어 SQL 인젝션 취약점 발생 가능.
🎯 Impact: 사용자가 악의적으로 세미콜론이 포함된 컬럼 타입을 입력할 경우, DDL 쿼리에 악성 쿼리가 삽입되어 실행될 위험이 있습니다.
🔧 Fix: `assertValidSqlType` 함수를 추가하여 컬럼 타입에 세미콜론이 포함될 경우 에러를 던지도록 하였습니다.
✅ Verification: 관련 유닛 테스트를 `packages/web/src/lib/erd.test.ts`에 추가하고 100% 테스트 커버리지를 유지함을 확인했습니다.

---

PR created automatically by Jules for task 14276269119169641456 started by @seonghobae

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 40 seconds

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c54c660c-ed62-48a0-b5bf-c89e9df2cbec

📥 Commits

Reviewing files that changed from the base of the PR and between 9ef092b and a85d94d.

📒 Files selected for processing (3)

• .jules/sentinel.md
• packages/web/src/lib/erd.test.ts
• packages/web/src/lib/erd.ts

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch sentinel-fix-sql-injection-erd-14276269119169641456

---

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

This PR hardens the ERD DDL generator in @argos/web by adding validation for user-provided column SQL types to reduce the risk of DDL/SQL injection via column.type interpolation.

Changes:

• Added assertValidSqlType and invoked it during ERDModel.addColumn() to reject semicolons in column.type.
• Added a unit test covering semicolon-containing column types.
• Documented the vulnerability and prevention note in .jules/sentinel.md.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
packages/web/src/lib/erd.ts	Adds SQL type validation and enforces it when adding columns.
packages/web/src/lib/erd.test.ts	Adds a regression test for semicolon-based injection attempts.
.jules/sentinel.md	Records the security learning/prevention note for this issue.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[seonghobae]

Superseded by #397. This predecessor only rejects semicolons in the ERD SQL type field. #397 is the current focused replacement on a newer base and fails closed with positive SQL-type/default grammar validation, identifier/foreign-key validation, protected validated state, and broader adversarial tests. Closing the stale competing fix; predecessor evidence is not reused.

[google-labs-jules]

Superseded by #397. This predecessor only rejects semicolons in the ERD SQL type field. #397 is the current focused replacement on a newer base and fails closed with positive SQL-type/default grammar validation, identifier/foreign-key validation, protected validated state, and broader adversarial tests. Closing the stale competing fix; predecessor evidence is not reused.

Understood. Acknowledging that this work is superseded by #397 and stopping work on this task.