🛡️ Sentinel: [CRITICAL] Fix DDL SQL Injection vulnerability in ERD Tool

[seonghobae]

🚨 Severity: CRITICAL
💡 Vulnerability: ERD 모델 설계 시, Column의 type 또는 defaultValue에 사용자가 임의의 SQL 종결자(;)를 삽입하여 부차적인 악성 SQL 구문(예: INTEGER; DROP TABLE users;)을 주입할 수 있었습니다. generateDDL은 이를 단순히 문자열로 결합하므로 치명적인 Injection 위험이 있었습니다.
🎯 Impact: 생성된 DDL 스크립트를 DB에서 실행할 시 테이블 삭제나 정보 유출 등 예상치 못한 다중 쿼리가 실행될 수 있습니다.
🔧 Fix:

• isUnique 및 defaultValue 기능을 추가함과 동시에, type과 defaultValue 입력값 내에 세미콜론(;)이 포함되었는지 명시적으로 확인하는 assertNoStatementTerminator 검증 로직을 추가했습니다.
• 에러 처리 테스트와 새로운 기능들에 대한 100% 테스트 커버리지를 구현했습니다.
  ✅ Verification: cd packages/web && pnpm coverage:erd 커맨드를 통해 테스트가 통과되는 것을 확인하였습니다.

---

PR created automatically by Jules for task 11455440601325647385 started by @seonghobae

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 23 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1f58d9bc-d85a-4840-9632-c176e161c56e

📥 Commits

Reviewing files that changed from the base of the PR and between 9ef092b and 2eaeb8c.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (11)

• .claude/skills/persuasion-review/scripts/probe_harness.py
• .jules/sentinel.md
• CHANGELOG.md
• package.json
• packages/cli/src/__tests__/transcript.test.ts
• packages/cli/src/commands/status.ts
• packages/cli/src/lib/inject-agent-hooks.ts
• packages/cli/src/lib/project.ts
• packages/cli/src/lib/transcript.test.ts
• packages/web/src/lib/erd.test.ts
• packages/web/src/lib/erd.ts

---

_{Comment @coderabbitai help to get the list of available commands.}

[seonghobae]

Closing as superseded by #397. This branch targets the same ERD DDL-injection boundary with a semicolon-denylist approach and has accumulated unrelated changes on an older base. PR #397 is the bounded replacement on the current developmental base: it covers the semicolon case plus constraint/grammar smuggling, arbitrary default-function execution, validated-input mutation, PostgreSQL identifier quoting, focused regression coverage, and current security doctoring. No review/check evidence from this predecessor is being reused for #397.

[google-labs-jules]

Closing as superseded by #397. This branch targets the same ERD DDL-injection boundary with a semicolon-denylist approach and has accumulated unrelated changes on an older base. PR #397 is the bounded replacement on the current developmental base: it covers the semicolon case plus constraint/grammar smuggling, arbitrary default-function execution, validated-input mutation, PostgreSQL identifier quoting, focused regression coverage, and current security doctoring. No review/check evidence from this predecessor is being reused for #397.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.