Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] ERD DDL 생성 μ‹œ SQL μΈμ μ…˜ λ°©μ§€ - #386

Closed
seonghobae wants to merge 3 commits into
developmentalfrom
sentinel-fix-erd-ddl-sqli-15134268217133873559
Closed

πŸ›‘οΈ Sentinel: [CRITICAL] ERD DDL 생성 μ‹œ SQL μΈμ μ…˜ λ°©μ§€#386
seonghobae wants to merge 3 commits into
developmentalfrom
sentinel-fix-erd-ddl-sqli-15134268217133873559

Conversation

@seonghobae

Copy link
Copy Markdown

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: ERD λ„κ΅¬μ—μ„œ DDL을 생성할 λ•Œ, 컬럼 νƒ€μž… λ¬Έμžμ—΄μ— μ„Έλ―Έμ½œλ‘ (;)을 ν¬ν•¨μ‹œμΌœ κΈ°μ‘΄ λ¬Έμž₯을 μ’…λ£Œν•˜κ³  μ•…μ˜μ μΈ SQL λ¬Έ(DROP TABLE λ“±)을 μ‚½μž…ν•  수 μžˆλŠ” SQL μΈμ μ…˜ 취약점이 μ‘΄μž¬ν–ˆμŠ΅λ‹ˆλ‹€.
🎯 Impact: μ•…μ˜μ μΈ μ‚¬μš©μžκ°€ μŠ€ν‚€λ§ˆ 생성 κΈ°λŠ₯을 μ•…μš©ν•˜μ—¬ λ°μ΄ν„°λ² μ΄μŠ€λ₯Ό μž„μ˜λ‘œ μ‘°μž‘ν•˜κ±°λ‚˜ νŒŒκ΄΄ν•  수 μžˆμŠ΅λ‹ˆλ‹€.
πŸ”§ Fix: 컬럼 νƒ€μž… λ¬Έμžμ—΄μ— ꡬ문 μ’…κ²°μž(μ„Έλ―Έμ½œλ‘ )κ°€ ν¬ν•¨λ˜μ–΄ μžˆλŠ”μ§€ κ²€μ‚¬ν•˜κ³  μ°¨λ‹¨ν•˜λŠ” assertNoStatementTerminator 헬퍼 ν•¨μˆ˜λ₯Ό μΆ”κ°€ν•˜μ—¬ SQL μΈμ μ…˜μ„ λ°©μ§€ν–ˆμŠ΅λ‹ˆλ‹€.
βœ… Verification: erd.test.ts에 μ„Έλ―Έμ½œλ‘ μ΄ ν¬ν•¨λœ 컬럼 νƒ€μž… μΆ”κ°€ μ‹œ μ˜ˆμ™Έκ°€ λ°œμƒν•˜λŠ”μ§€ ν™•μΈν•˜λŠ” ν…ŒμŠ€νŠΈ μ½”λ“œλ₯Ό μΆ”κ°€ν–ˆμœΌλ©°, λͺ¨λ“  ν…ŒμŠ€νŠΈκ°€ 정상 ν†΅κ³Όν•˜λŠ” 것을 ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€.


PR created automatically by Jules for task 15134268217133873559 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 21 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
βš™οΈ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1f90ac47-7154-4ef8-acd4-ed950bed21dd

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 085aea3 and 57d8f3d.

β›” Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
πŸ“’ Files selected for processing (4)
  • .jules/sentinel.md
  • package.json
  • packages/web/src/lib/erd.test.ts
  • packages/web/src/lib/erd.ts

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Author

Superseded by #397. The replacement is rebased onto the newer developmental line and closes the same ERD DDL-injection boundary more completely: instead of only rejecting semicolons, it uses positive SQL-type/default grammar validation, validates identifiers/foreign-key inputs, snapshots caller-owned model state to prevent post-validation mutation, and adds broader adversarial regression coverage. Keeping both PRs open creates a competing security-fix path and stale-base review noise, so this narrower predecessor is being closed without reusing its checks or reviews.

@seonghobae seonghobae closed this Aug 7, 2026
@google-labs-jules

Copy link
Copy Markdown

Superseded by #397. The replacement is rebased onto the newer developmental line and closes the same ERD DDL-injection boundary more completely: instead of only rejecting semicolons, it uses positive SQL-type/default grammar validation, validates identifiers/foreign-key inputs, snapshots caller-owned model state to prevent post-validation mutation, and adds broader adversarial regression coverage. Keeping both PRs open creates a competing security-fix path and stale-base review noise, so this narrower predecessor is being closed without reusing its checks or reviews.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant