๐จ Palette: Add contextual ARIA labels to table edit modal actions - #752
๐จ Palette: Add contextual ARIA labels to table edit modal actions#752seonghobae wants to merge 2 commits into
Conversation
- Added dynamic, context-aware `aria-label`s to the "ํ ์ด๋ธ ์ญ์ " (Delete) and "๋ณต์ " (Duplicate) buttons in `EditTableModal.tsx`. - Updated test matchers in `EditTableModal.test.tsx` and `ModalCoverage.test.tsx` to match the new accessible names. - Improves screen reader comprehension of destructive and duplication actions.
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 1 minute Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review detailsโ๏ธ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ๐ Files selected for processing (3)
Comment |
|
@opencode-agent @cwl-noema-review Please perform a fresh independent review of current head |
Acknowledged. |
|
@coderabbitai review Review the exact live head only. Verify edit-table Delete and Duplicate controls include the current table name in stable localized accessible names without duplicating or exposing unsafe markup, update correctly when table context changes, preserve destructive-action confirmation and keyboard/focus behavior, and have focused screen-reader-oriented tests. Require complete frontend typecheck/tests/100% coverage/build, security gates, and zero unresolved threads. Review only; do not update the branch, merge, release, or alter protections. |
|
|
Acknowledged. |
|
Exact-current-head review request for @coderabbitai review Do not modify the branch, bypass protection, merge, tag, release, or publish. |
Acknowledged. |
๐งฉ Analysis chain๐ Script executed: #!/bin/bash
set -euo pipefail
expected='2d6183160cb095b35cf4498d5058dff049f604a9'
printf '%s\n' '== checked-out commit =='
git rev-parse HEAD
printf '%s\n' '== requested commit exists =='
git cat-file -t "$expected"
printf '%s\n' '== focused diff against first parent =='
git diff --stat "${expected}^" "$expected"
git diff --find-renames --unified=80 "${expected}^" "$expected"
printf '%s\n' '== changed files at requested commit =='
git diff-tree --no-commit-id --name-only -r "$expected"
printf '%s\n' '== source and test symbol map =='
changed_files=$(git diff-tree --no-commit-id --name-only -r "$expected")
for f in $changed_files; do
case "$f" in
*.ts|*.tsx|*.js|*.jsx)
printf '\n-- %s --\n' "$f"
ast-grep outline "$f" --items all 2>/dev/null || true
;;
esac
done
printf '%s\n' '== relevant accessible-name, confirmation, and focus references =='
rg -n -i -C 5 \
'(aria-label|aria-labelledby|Delete|Duplicate|๋ณต์ |ํ
์ด๋ธ ์ญ์ |confirm|dialog|modal|focus|keyboard)' \
$changed_files || true
printf '%s\n' '== live PR head, checks, and reviews =='
gh pr view 752 --repo ContextualWisdomLab/pg-erd-cloud \
--json headRefOid,statusCheckRollup,reviews,reviewThreads \
--jq '{headRefOid, checks: [.statusCheckRollup[] | {name, status, conclusion}], reviews: [.reviews[] | {author: .author.login, state}], threads: [.reviewThreads[] | {isResolved, isOutdated}]}'Length of output: 26115 ๐ Script executed: #!/bin/bash
set -euo pipefail
repo='ContextualWisdomLab/pg-erd-cloud'
pr='752'
expected='2d6183160cb095b35cf4498d5058dff049f604a9'
printf '%s\n' '== supported PR metadata =='
gh pr view "$pr" --repo "$repo" \
--json headRefOid,baseRefOid,baseRefName,changedFiles,files,commits,statusCheckRollup,reviews,reviewDecision,url \
--jq '{url, headRefOid, baseRefOid, baseRefName, changedFiles, files: [.files[].path], commits: [.commits[] | {oid: .oid, messageHeadline: .messageHeadline}], checks: [.statusCheckRollup[] | {name, status, conclusion}], reviewDecision, reviews: [.reviews[] | {author: .author.login, state}]}'
printf '%s\n' '== PR review-thread state through GraphQL =='
gh api graphql \
-F owner='ContextualWisdomLab' \
-F name='pg-erd-cloud' \
-F number="$pr" \
-f query='
query($owner: String!, $name: String!, $number: Int!) {
repository(owner: $owner, name: $name) {
pullRequest(number: $number) {
headRefOid
reviewThreads(first: 100) {
nodes { isResolved isOutdated path line originalLine }
}
}
}
}' \
--jq '{head: .data.repository.pullRequest.headRefOid, threads: [.data.repository.pullRequest.reviewThreads.nodes[] | select(.isResolved == false) | {isOutdated, path, line, originalLine}]}'
base=$(gh pr view "$pr" --repo "$repo" --json baseRefOid --jq .baseRefOid)
printf '%s\n' '== complete PR diffstat =='
git diff --stat "$base" "$expected"
printf '%s\n' '== complete changed-file list =='
git diff --name-only "$base" "$expected"
printf '%s\n' '== complete PR patch =='
git diff --find-renames --unified=100 "$base" "$expected"
printf '%s\n' '== relevant file outlines and focused content =='
git diff --name-only "$base" "$expected" |
while IFS= read -r f; do
case "$f" in
*.ts|*.tsx|*.js|*.jsx)
printf '\n-- outline: %s --\n' "$f"
ast-grep outline "$f" --items all 2>/dev/null || true
printf '\n-- accessibility and interaction context: %s --\n' "$f"
rg -n -i -C 12 \
'(aria-label|aria-labelledby|table.*delete|delete.*table|duplicate|๋ณต์ |ํ
์ด๋ธ ์ญ์ |window\.confirm|confirm\(|onKeyDown|Escape|Enter|focus)' \
"$f" || true
;;
esac
doneLength of output: 45565 ๐ Script executed: #!/bin/bash
set -euo pipefail
printf '%s\n' '== EditTableModal call sites and delete-handler definitions =='
rg -n -C 10 \
'(?:<EditTableModal\b|onDeleteTable=|const\s+handleDeleteTable|function\s+handleDeleteTable|onDeleteTable\s*[:=])' \
frontend --glob '*.{ts,tsx}'
printf '%s\n' '== dialog accessibility hook and test files =='
fd -t f 'useDialogAccessibility' frontend
fd -t f -i 'dialog.*test|modal.*test' frontend |
while IFS= read -r f; do
if rg -q '(useDialogAccessibility|EditTableModal|Escape|focus|keyboard)' "$f"; then
printf '%s\n' "-- $f --"
rg -n -i -C 12 '(useDialogAccessibility|EditTableModal|Escape|focus|keyboard)' "$f"
fi
done
printf '%s\n' '== focused source regions =='
hook=$(fd -t f 'useDialogAccessibility' frontend | head -n 1)
if [ -n "$hook" ]; then
cat -n "$hook"
fi
printf '%s\n' '== tests that verify rerendered contextual accessible names =='
rg -n -i -C 8 \
'(rerender|aria-label|accessible name|getByRole\(.+ํ
์ด๋ธ (์ญ์ |๋ณต์ )|getByRole\(.+Delete|ํ
์ด๋ธ ์ญ์ |ํ
์ด๋ธ ๋ณต์ )' \
frontend/src --glob '*.{test,spec}.{ts,tsx}' || trueLength of output: 80826 ๐ Script executed: #!/bin/bash
set -euo pipefail
printf '%s\n' '== all parent Delete handler references =='
rg -n -C 25 '\bonDeleteTable\b' frontend/src/App.tsx
printf '%s\n' '== parent confirmation and table-delete tests =='
rg -n -i -C 20 \
'(onDeleteTable|ํ
์ด๋ธ์ ์ญ์ |table.*delete|delete.*table|window\.confirm|confirm\()' \
frontend/src --glob '*.{test,spec}.{ts,tsx}' \
--glob '!components/modals/EditTableModal.test.tsx' \
--glob '!components/modals/ModalCoverage.test.tsx' || true
printf '%s\n' '== direct safe rendering references for table titles =='
rg -n -C 5 \
'(editingNode\.data\.title|data\.title.*aria-label|aria-label.*data\.title)' \
frontend/src/components/modals/EditTableModal.tsx frontend/src/App.tsxLength of output: 46540
Finding โ test coverage gap
Add a focused regression test that rerenders the open modal with another table name. Assert that both controls change to the new localized names:
This verifies the required table-context update behavior. Verified behavior:
|
1 participant
๐ก What: Added dynamic, context-aware
aria-labels to the 'ํ ์ด๋ธ ์ญ์ ' (Delete) and '๋ณต์ ' (Duplicate) buttons in the Edit Table modal.๐ฏ Why: Previously, these buttons only had generic text, which could confuse screen reader users who might lose context of exactly which table they are modifying. By injecting the table's name into the ARIA label, assistive technologies provide full context.
๐ธ Before/After: No visual changes, accessibility markup only.
โฟ Accessibility: Greatly improves screen reader comprehension for destructive and duplication actions.
PR created automatically by Jules for task 17543974417981148235 started by @seonghobae