Skip to content

More efficient check of references in save&restore#3805

Merged
shroffk merged 3 commits into
masterfrom
CSSTUDIO-3725-d
May 19, 2026
Merged

More efficient check of references in save&restore#3805
shroffk merged 3 commits into
masterfrom
CSSTUDIO-3725-d

Conversation

@georgweiss
Copy link
Copy Markdown
Collaborator

Recently added: annotation of save&restore snapshot and composite snapshots referenced in any composite snapshot. The implementation however is very inefficient as it generates queries to the service whenever JavaFX determines that the TreeCell must be re-rendered.

This PR abandons the annotation strategy to instead disable the Delete menu item if references are found. This way the call to the service happens only when context menu is launched, and only for the selected node, so user will be able to determine if a snapshot or composite snapshot can be deleted before attempting the operation.

  • Testing:

    • The feature has automated tests
    • [ X] Tests were run
  • Documentation:

    • The feature is documented
    • [ X] The documentation is up to date
    • Release notes:
      • Added an entry if the change is breaking or significant
      • Added an entry when adding a new feature

@georgweiss georgweiss requested a review from jacomago May 19, 2026 09:06
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@georgweiss georgweiss requested a review from shroffk May 19, 2026 11:56
@shroffk shroffk merged commit db2460d into master May 19, 2026
4 of 5 checks passed
@shroffk shroffk deleted the CSSTUDIO-3725-d branch May 19, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants