fix: propagate pgbackrest info failures#4482
Open
immanuwell wants to merge 1 commit into
Open
Conversation
Contributor
|
Hi @immanuwell, CI failures look mostly mechanical: vulnerabilities (govulncheck), e2e-k3d-chainsaw, and e2e-k3d-kuttl will all clear with a rebase onto current main — they're all from changes that landed since this PR was opened (x/net v0.54 in #4481, chainsaw/kuttl Go pin revert in #4488). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix for
pgbackrest_info.sh.Right now the script prints
|, runspgbackrest info, then always reachesecho. So ifpgbackrestexits non-zero, the helper can still look green. sneaky little footgun.Repro:
Before: exits
0.After: exits
42.This is reachable in real clusters:
pgbackrest infocan fail from config/stanza issues, repo storage or network errors, missing binaries in a bad image, or an OOM/signal. No cloud quota edge-case needed here.Tested:
go test ./components/... -count=1Related: #3293