chore: extract glob for pyupgrade to separate script for cross-platform compatibility#950
Merged
jkowalleck merged 6 commits intoCycloneDX:mainfrom Mar 23, 2026
Merged
Conversation
jkowalleck
requested changes
Mar 17, 2026
peschuster
force-pushed
the
pyupgrade-crossplatform
branch
from
0730b36 to
f91065d
Compare
…rm compatibility 'sh' in tox.ini does not work on Windows in PowerShell. Signed-off-by: Peter Schuster <p.schuster@pilz.de>
peschuster
force-pushed
the
pyupgrade-crossplatform
branch
from
f91065d to
53bb407
Compare
jkowalleck
approved these changes
Mar 23, 2026
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Member
|
thank you very much for taking care of this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently pyupgrade cannot be run on Windows due to 'sh' in tox.ini not working in PowerShell.
Adding a separate script for this might be controversial.
I could not find another solution that is platform independent, except from inline python in tox.ini which got "complicated" due to
{posargs}. However, if anyone has a better idea, this could be reworked.AI Tool Disclosure
Affirmation