fix: avoid nil pointer panic when vulnerability analysis omits response (#148)#149
Open
SAY-5 wants to merge 1 commit into
Open
fix: avoid nil pointer panic when vulnerability analysis omits response (#148)#149SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
…s response (CycloneDX#148) Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
SAY-5
force-pushed
the
fix-vuln-analysis-nil-response
branch
from
43c9017 to
59e4a4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CycloneDX
analysis.responsearray is optional. When a vulnerability has ananalysisobject but noresponse,HashmapVulnerabilitydereferenced the nil*[]stringpointer and panicked withinvalid memory address or nil pointer dereferenceatschema/bom_hash.go:392(reported in #148, also reproduced locally).This guards the dereference and keeps the existing
UNDEFINEDplaceholder fallback.Test
Added
TestHashCDXVulnerabilityAnalysisWithoutResponseinschema/bom_hash_test.go, which panics onmainand passes with the fix.go test ./schema/andgo vet ./schema/pass.