[HOTFIX] ProfileInputView BottomSheet 컴파일 오류 수정#52
Merged
Conversation
- ProfileInputView: buttons 배열을 primaryButton/secondaryButton으로 교체 - AuthFlowFeature: guard let을 Effect.run 밖으로 이동해 불필요한 Task 생성 방지 Closes #51
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| if case .departure = state.path[id: id] { return true } | ||
| return false | ||
| } | ||
| guard let id = departureID else { return .none } |
There was a problem hiding this comment.
🟡 [P3] Minor
guard let을 Effect.run 밖으로 이동하여 departureID가 없을 때 불필요한 Task 생성을 방지한 좋은 개선입니다. Effect 생성 전에 조건을 확인하여 효율적인 로직 흐름을 만듭니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요
PR #49에서
BottomSheetAPI를buttons: [ButtonConfig]배열에서primaryButton: ButtonConfig?/secondaryButton: ButtonConfig?옵셔널 파라미터로 변경하였으나,ProfileInputView의 호출부가 누락되어 컴파일 오류가 발생하는 문제를 긴급 수정합니다.변경 사항
ProfileInputView:buttons: [...]→primaryButton:/secondaryButton:파라미터로 교체AuthFlowFeature:guard let을Effect.run밖으로 이동하여 departureID가 없을 때 불필요한 Task 생성 방지To Reviewer
ProfileInputView의 BottomSheet 호출부가 API 변경에서 누락된 부분을 수정하였습니다.AuthFlowFeature의guard let위치 개선도 함께 포함되어 있습니다.Closes #51