Improvement: Cad geometry component test#2150
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2150 +/- ##
==========================================
+ Coverage 82.59% 82.66% +0.06%
==========================================
Files 115 117 +2
Lines 18548 18693 +145
==========================================
+ Hits 15320 15452 +132
- Misses 3228 3241 +13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Davknapp
requested changes
May 12, 2026
Co-authored-by: David Knapp <david.knapp@dlr.de>
Davknapp
reviewed
Jun 8, 2026
Davknapp
left a comment
Collaborator
There was a problem hiding this comment.
Please fix the failing testsuite - then we should be ready to merge.
Davknapp
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2343
Describe your changes here:
This PR adds a cad geometry component test. It refines a curved base forest and checks if it matches a target forest. This tests the msh reader as well as the cad geometries.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).