feat: implements healpix geometry#2327
Open
faouziH21 wants to merge 5 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2327 +/- ##
==========================================
+ Coverage 78.45% 81.97% +3.52%
==========================================
Files 115 119 +4
Lines 19184 18689 -495
==========================================
+ Hits 15050 15320 +270
+ Misses 4134 3369 -765 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Davknapp
requested changes
May 21, 2026
Davknapp
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the addition! Please address my comments. I am looking forward to merge it!
Collaborator
|
Please use our indentation script to fix the indentation. Also have a look at the output of the doxygen check to see which functions need documentation. |
Co-authored-by: David Knapp <david.knapp@dlr.de>
Davknapp
reviewed
Jun 9, 2026
| #include <t8.h> | ||
| #include <t8_geometry/t8_geometry_with_vertices.hxx> | ||
|
|
||
| struct t8_geometry_healpix: public t8_geometry_with_vertices |
Collaborator
There was a problem hiding this comment.
Please document the struct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2329
Describe your changes here:
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
scripts/internal/find_all_source_files.shto check the indentation of these files.License
doc/(or already has one).