Skip to content

Cleanup old ccm features#2542

Merged
jwillemsen merged 1 commit into
DOCGroup:masterfrom
jwillemsen:jwi-oldccmfeatures
May 19, 2026
Merged

Cleanup old ccm features#2542
jwillemsen merged 1 commit into
DOCGroup:masterfrom
jwillemsen:jwi-oldccmfeatures

Conversation

@jwillemsen
Copy link
Copy Markdown
Member

@jwillemsen jwillemsen commented May 19, 2026

* ACE/bin/MakeProjectCreator/config/global.features:

Summary by CodeRabbit

  • Chores
    • Removed feature configuration entries related to CORBA Component Model (CCM) and DDS4CCM components from project settings.

Review Change Stack

    * ACE/bin/MakeProjectCreator/config/global.features:
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 36d383ce-2ca3-4f5d-aafb-aecf722aedfe

📥 Commits

Reviewing files that changed from the base of the PR and between acb6815 and 87d80b3.

📒 Files selected for processing (1)
  • ACE/bin/MakeProjectCreator/config/global.features
💤 Files with no reviewable changes (1)
  • ACE/bin/MakeProjectCreator/config/global.features

Walkthrough

This PR removes twelve deprecated feature flag definitions from the ACE MakeProjectCreator global features configuration: the ofccm feature, four DDS4CCM variants, and three CCM-related feature flags.

Changes

Feature definition cleanup

Layer / File(s) Summary
Remove deprecated feature definitions
ACE/bin/MakeProjectCreator/config/global.features
Removes ofccm, dds4ccm_opendds, dds4ccm_ndds, dds4ccm_splice, dds4ccm_coredx, ccm_lw, ccm_noevent, and ccm_direct_collocation feature flag entries from the global configuration.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🐰 A simple cleanup tale so neat,
Old features removed, no longer sweet,
The config grows lean and light,
With deprecated flags out of sight,
The build system now feels right!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Cleanup old ccm features' accurately summarizes the main change: removing deprecated CCM-related feature definitions from global.features.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@jwillemsen jwillemsen merged commit cc8db73 into DOCGroup:master May 19, 2026
39 checks passed
@jwillemsen jwillemsen deleted the jwi-oldccmfeatures branch May 19, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant