Remove nwis.py functions with defunct services#216
Closed
ehinman wants to merge 5 commits intoDOI-USGS:mainfrom
Closed
Remove nwis.py functions with defunct services#216ehinman wants to merge 5 commits intoDOI-USGS:mainfrom
ehinman wants to merge 5 commits intoDOI-USGS:mainfrom
Conversation
thodson-usgs
changed the title
thodson-usgs
approved these changes
Feb 25, 2026
Collaborator
thodson-usgs
left a comment
thodson-usgs
left a comment
There was a problem hiding this comment.
I haven't confirmed whether these APIs are defunct. Assuming they are, I approve.
Please note that deprecated does not mean defunct, and it's important to keep them straight so we don't confuse users.
dataretrieval/nwis.py
Outdated
Comment on lines
+152
to
+154
| Get discharge measurements from the waterdata service - | ||
| deprecated, use `get_field_measurements()` in the waterdata | ||
| module. |
Collaborator
There was a problem hiding this comment.
Suggested change
| Get discharge measurements from the waterdata service - | |
| deprecated, use `get_field_measurements()` in the waterdata | |
| module. | |
| This endpoint is defunct, use `get_field_measurements()` in the waterdata | |
| module. |
Rephrase as you like.
Collaborator
|
Scanning through this, I agree that the api's that are listed in this PR as "defunk" are GONE, and the ones listed as "deprecated" are still around but have a better waterdata equivalent. |
Collaborator
|
Sorry. I linted the package before merging this, so I might close this and redo it. |
thodson-usgs
added a commit
to thodson-usgs/dataretrieval-python
that referenced
this pull request
Apr 2, 2026
Collaborator
Author
|
Thanks @thodson-usgs and @ldecicco-USGS!! |
thodson-usgs
added a commit
that referenced
this pull request
Apr 3, 2026
Remove defunct nwis functions (recreation of PR #216)
Collaborator
|
Closed by #222 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add name errors and deprecation language for:
get_gwlevelsget_discharge_measurementsget_pmcodesget_water_useI did not edit the example notebooks from Hydroshare. Are these still being used? Should they be updated or removed?