fix: use public Testnet RPC for BENS - #197
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_2ae5f218-f7b5-4b17-99ae-2f89a24edc6e) |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the BENS configuration, Docker Compose setup, and validation scripts to use the canonical public Testnet RPC URL (https://test.doschain.com/) instead of the previous internal RPC URL. Feedback on the changes suggests referencing the CANONICAL_TESTNET_BENS_RPC constant from the validator module in the test script to avoid hardcoding the URL and ensure they remain in sync.
| @@ -54,10 +54,6 @@ def test_bens_database_password_is_not_hardcoded(self): | |||
|
|
|||
| def test_bens_uses_canonical_testnet_rpcs(self): | |||
| public_rpc = "https://test.doschain.com/" | |||
There was a problem hiding this comment.
Instead of hardcoding the public RPC URL here, you can reference self.module.CANONICAL_TESTNET_BENS_RPC which is already defined in the validator script. This avoids duplication and ensures the test remains in sync with the validator automatically.
| public_rpc = "https://test.doschain.com/" | |
| public_rpc = self.module.CANONICAL_TESTNET_BENS_RPC |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_a9e0472f-b0f8-4f24-84dd-1b13c9d0760f) |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_b380b696-aaf5-4d66-93a9-90eee56e969e) |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_af84369d-c512-4028-8ec8-cf11fcebf29b) |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_7b47b85b-cd63-4fcf-bf51-809e1e375825) |
4f629d3 to
8ce63af
Compare
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_a8345ef1-ebfa-4097-ba23-83a130d24e43) |
1 participant
Summary\n- point Testnet BENS and Graph Node at the reachable public DOS Chain RPC\n- pin the merged ENSv2 Testnet deployment record without changing the Mainnet source pin\n- select deploy targets from the full push diff, so Testnet-only changes do not redeploy Mainnet\n- keep the BENS validator and regression tests aligned\n\n## Validation\n- actionlint .github/workflows/deploy-config.yml\n- python scripts/validate-testnet-bens.py\n- python .github/scripts/tests/test_validate_testnet_bens.py -k bens_uses_canonical_testnet_rpcs\n- python .github/scripts/tests/test_validate_testnet_bens.py -k push_deploys_only_affected_environment\n- python .github/scripts/tests/test_validate_testnet_bens.py -k deployment_fetches_an_immutable_dos_names_revision\n- docker compose -f docker-compose/docker-compose-testnet.yml config --no-interpolate --quiet\n- eth_chainId against https://test.doschain.com/ returned 0xf63\n\nFull Testnet validator-suite execution is delegated to Ubuntu CI. Its Windows-only jq fallback stalled locally and was stopped without source changes.
Note
Medium Risk
Touches live Testnet BENS/Graph Node RPC and production deploy gating. A path-filter miss could skip or trigger the wrong GCP environment.
Overview
Points Testnet BENS and Graph Node at the public
https://test.doschain.com/RPC instead of the private10.148.0.7AvalancheGo URL, so name-service indexing can reach a working endpoint.Splits DOS Names pins: Mainnet stays on
62243956…; Testnet (and dependency CI) move to130d42ae…for the merged ENSv2 testnet record.Adds a
changesjob so push deploys only the affected environment from the full git diff (plus subgraph-ref line diffs). Manual dispatch still selects a single target. Validators and tests now require the public RPC and per-env deploy gating.Reviewed by Cursor Bugbot for commit 8ce63af. Bugbot is set up for automated code reviews on this repo. Configure here.