Skip to content

feat(nakama): add actor profile registry #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JOY (JOY) merged 6 commits into from
May 16, 2026
Merged

feat(nakama): add actor profile registry #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4fa817b
feat(nakama): add actor profile registry
JOY May 16, 2026
17868d4
feat(unity): expose actor profile RPC client
JOY May 16, 2026
06db4d9
fix(nakama): preserve zero actor values
JOY May 16, 2026
5da90d1
fix(nakama): persist normalized actor profiles
JOY May 16, 2026
af499a4
fix(nakama): tighten actor profile storage keys
JOY May 16, 2026
ca4087e
fix(nakama): harden actor profile creation
JOY May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions Unity/Assets/_SecondSpawn/Scripts/AI/AgentContextDto.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,21 @@ public sealed class AgentContextDto
public BodyProfileDto body;
}

[Serializable]
public sealed class ActorProfileDto
{
public string actor_id;
public string actor_type;
public string owner_player_id;
public string display_name;
public BodyProfileDto body;
public MemoryRecordDto[] memory;
public AgentRuntimeDto agent_runtime;
public AgentActivityRecordDto[] agent_activity;
Comment on lines +20 to +22
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The ActorProfileDto contains memory, agent_runtime, and agent_activity fields at the root level, but these fields also exist within the BodyProfileDto (lines 47-49). This duplication creates inconsistency between the player profile (which uses body.memory) and the actor profile. It is recommended to move these behavioral state fields into the body object for actors as well, ensuring a consistent interface for all entities.

public string created_at;
public string updated_at;
}

[Serializable]
public sealed class PlayerProfileDto
{
Expand Down Expand Up @@ -165,6 +180,32 @@ public sealed class UpdateSoulRequestDto
public AgentPolicyDto agent_policy;
}

[Serializable]
public sealed class ActorProfileRequestDto
{
public string actor_id;
public string actor_type = "npc";
public string display_name;
public string archetype_id;
public string visual_prefab_key;
public CharacterStatsDto stats;
public CharacterTraitsDto characteristics;
public BodyTimeDto time;
public CultivationDto cultivation;
public SoulProfileDto soul;
public AgentPolicyDto agent_policy;
}

[Serializable]
public sealed class ActorMemoryAddRequestDto
{
public string actor_id;
public string id;
public string kind = "system";
public string summary;
public int importance = 5;
}

[Serializable]
public sealed class AgentDecisionRequestDto
{
Expand Down
15 changes: 15 additions & 0 deletions Unity/Assets/_SecondSpawn/Scripts/AI/SecondSpawnGatewayClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,21 @@ public IEnumerator AddNakamaMemory(MemoryRecordDto memory, Action<AgentContextDt
yield return SendNakamaRpc("secondspawn_memory_add", memory, onSuccess, onError);
}

public IEnumerator GetNakamaActorProfile(string actorId, Action<ActorProfileDto> onSuccess, Action<string> onError = null)
{
yield return GetNakamaActorProfile(new ActorProfileRequestDto { actor_id = actorId }, onSuccess, onError);
}

public IEnumerator GetNakamaActorProfile(ActorProfileRequestDto request, Action<ActorProfileDto> onSuccess, Action<string> onError = null)
{
yield return SendNakamaRpc("secondspawn_actor_profile_get", request, onSuccess, onError);
}

public IEnumerator AddNakamaActorMemory(ActorMemoryAddRequestDto memory, Action<ActorProfileDto> onSuccess = null, Action<string> onError = null)
{
yield return SendNakamaRpc("secondspawn_actor_memory_add", memory, onSuccess, onError);
}

public IEnumerator AddNakamaAgentActivity(AgentActivityRecordDto activity, Action<AgentContextDto> onSuccess = null, Action<string> onError = null)
{
yield return SendNakamaRpc("secondspawn_agent_activity_add", activity, onSuccess, onError);
Expand Down
Loading
Loading